actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

New metric/hack: CheckpointsTapsSeparateJudgment. Deals with Hold checkpoints with taps interspersed. True = current/Pump Pro behavior. False = classic Pump It Up behavior. Hopefully this can be cleaned up later.

Browse Source
This commit is contained in:
Jason Felds
2009-05-24 00:11:23 +00:00
parent 568d60af49
commit 85e81e0c0f
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/Themes/default/metrics.ini
+1
View File
@@ -2385,6 +2385,7 @@ RequireStepOnHoldHeads=true
CheckpointsUseTimeSignatures=false CheckpointsUseTimeSignatures=false
InitialHoldLife=1 InitialHoldLife=1
RollBodyIncrementsCombo=true RollBodyIncrementsCombo=true
CheckpointsTapsSeparateJudgment=true
[PlayerShared] [PlayerShared]
Fallback="Player" Fallback="Player"
stepmania/Themes/pump/metrics.ini
+1
View File
@@ -22,6 +22,7 @@ CheckpointsUseTimeSignatures=true
ImmediateHoldLetGo=true ImmediateHoldLetGo=true
RollBodyIncrementsCombo=false RollBodyIncrementsCombo=false
InitialHoldLife=1 InitialHoldLife=1
CheckpointsTapsSeparateJudgment=false
[ScreenGameplay] [ScreenGameplay]
FailOnMissCombo=51 FailOnMissCombo=51
stepmania/src/Player.cpp
+3 -1
View File
@@ -134,6 +134,7 @@ ThemeMetric<bool> CHECKPOINTS_USE_TIME_SIGNATURES ( "Player", "CheckpointsUseTim
ThemeMetric<bool> IMMEDIATE_HOLD_LET_GO ( "Player", "ImmediateHoldLetGo" ); ThemeMetric<bool> IMMEDIATE_HOLD_LET_GO ( "Player", "ImmediateHoldLetGo" );
ThemeMetric<bool> REQUIRE_STEP_ON_HOLD_HEADS ( "Player", "RequireStepOnHoldHeads" ); ThemeMetric<bool> REQUIRE_STEP_ON_HOLD_HEADS ( "Player", "RequireStepOnHoldHeads" );
ThemeMetric<bool> ROLL_BODY_INCREMENTS_COMBO ( "Player", "RollBodyIncrementsCombo" ); ThemeMetric<bool> ROLL_BODY_INCREMENTS_COMBO ( "Player", "RollBodyIncrementsCombo" );
ThemeMetric<bool> CHECKPOINTS_TAPS_SEPARATE_JUDGMENT ( "Player", "CheckpointsTapsSeparateJudgment" );
float Player::GetWindowSeconds( TimingWindow tw ) float Player::GetWindowSeconds( TimingWindow tw )
@@ -2622,7 +2623,8 @@ void Player::CrossedRows( int iLastRowCrossed, const RageTimer &now )
} }
} }
if( !viColsWithHold.empty() ) // TODO: Find a better way of handling hold checkpoints with other taps.
if( !viColsWithHold.empty() && ( CHECKPOINTS_TAPS_SEPARATE_JUDGMENT || m_NoteData.GetNumTapNotesInRow( iLastRowCrossed ) == 0 ) )
{ {
HandleHoldCheckpoint( r, iNumHoldsHeldThisRow, iNumHoldsMissedThisRow, viColsWithHold ); HandleHoldCheckpoint( r, iNumHoldsHeldThisRow, iNumHoldsMissedThisRow, viColsWithHold );
} }