View the list:

* Added new metric to cap the max life of a hold. No sanity checking yet: need a way to keep <= 1.
* Added more Pump specific behavior to lua.
* Fixed combo and hold judgment graphics due to it being defined twice.

Minor cleanup of the ProductivityHelpers is going to have to happen later on.

Themes/default/Scripts/03 ProductivityHelpers.lua

@@ -0,0 +1,49 @@
+function HitCombo()
+	sGame = GAMESTATE:GetCurrentGame():GetName();
+	local Combo = {
+		dance = 2,
+		pump = 4,
+		beat = 2,
+		kb7 = 2,
+		para = 2,
+	};
+	return Combo[sGame]
+end;
+
+function MissCombo()
+	sGame = GAMESTATE:GetCurrentGame():GetName();
+	local Combo = {
+		dance = 2,
+		pump = 4,
+		beat = cmd(),
+		kb7 = cmd(),
+		para = cmd(),
+	};
+	return Combo[sGame]
+end;
+
+function FailCombo() -- The combo that causes game failure.
+	sGame = GAMESTATE:GetCurrentGame():GetName();
+	local Combo = {
+		dance = "30", -- ITG/Pump Pro does it this way.
+		pump = "51",
+		beat = "-1",
+		kb7 = "-1",
+		para = "-1",
+	};
+	return Combo[sGame]
+end;
+
+function HoldJudgmentFail()
+	if GAMESTATE:GetCurrentGame():GetName() == "pump" then
+		return cmd();
+	else return cmd(finishtweening;shadowlength,0;diffusealpha,1;zoom,1;y,-10;linear,0.8;y,10;sleep,0.5;linear,0.1;zoomy,0.5;zoomx,2;diffusealpha,0);
+	end;
+end;
+
+function HoldJudgmentPass()
+	if GAMESTATE:GetCurrentGame():GetName() == "pump" then
+		return cmd();
+	else return cmd(finishtweening;shadowlength,0;diffusealpha,1;zoom,1.25;linear,0.3;zoomx,1;zoomy,1;sleep,0.5;linear,0.1;zoomy,0.5;zoomx,2;diffusealpha,0);
+	end;
+end;

Themes/default/metrics.ini

@@ -31,7 +31,8 @@ ShowQMarksInRandomCycle=true
 [HelpDisplay]
 TipShowTime=7
 [Combo]
-ShowComboAt=2
+ShowComboAt=HitCombo()
+ShowMissesAt=MissCombo()
 
 NumberMinZoom=0.8
 NumberMaxZoom=1
@@ -43,8 +44,8 @@ LabelOnCommand=x,6;y,22;shadowlength,1;horizalign,left;vertalign,bottom
 
 [HoldJudgment]
 # !!! #
-HoldJudgmentLetGoCommand=finishtweening;shadowlength,0;diffusealpha,1;zoom,1;y,-10;linear,0.8;y,10;sleep,0.5;linear,0.1;zoomy,0.5;zoomx,2;diffusealpha,0
-HoldJudgmentHeldCommand=finishtweening;shadowlength,0;diffusealpha,1;zoom,1.25;linear,0.3;zoomx,1;zoomy,1;sleep,0.5;linear,0.1;zoomy,0.5;zoomx,2;diffusealpha,0
+HoldJudgmentLetGoCommand=HoldJudgmentFail()
+HoldJudgmentHeldCommand=HoldJudgmentPass()
 
 [Judgment]
 # New #