actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

nullptr check + use const ref

Browse Source
This commit is contained in:
teejusb
2025-03-23 01:57:37 -07:00
parent ba067092ac
commit 7d0a31ef1a
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/SongManager.cpp
+4 -1
View File
@@ -682,7 +682,7 @@ bool SongManager::DoesSongGroupExist( RString sSongGroup ) const
return find( m_sSongGroupNames.begin(), m_sSongGroupNames.end(), sSongGroup ) != m_sSongGroupNames.end(); return find( m_sSongGroupNames.begin(), m_sSongGroupNames.end(), sSongGroup ) != m_sSongGroupNames.end();
} }
bool SongManager::HasPackIni(RString sSongGroup) const bool SongManager::HasPackIni(const RString& sSongGroup) const
{ {
Group* group = GetGroupFromName(sSongGroup); Group* group = GetGroupFromName(sSongGroup);
if(group != nullptr) if(group != nullptr)
@@ -937,6 +937,9 @@ std::vector<Song*> SongManager::GetPreferredSortSongsBySectionName( const RStrin
Group* SongManager::GetGroup( const Song* pSong ) const Group* SongManager::GetGroup( const Song* pSong ) const
{ {
if ( pSong == nullptr ) {
return nullptr;
}
return GetGroupFromName( pSong->m_sGroupName ); return GetGroupFromName( pSong->m_sGroupName );
} }
src/SongManager.h
+1 -1
View File
@@ -98,7 +98,7 @@ public:
//RString GetSongGroupBackgroundPath( RString sSongGroup ) const; //RString GetSongGroupBackgroundPath( RString sSongGroup ) const;
void GetSongGroupNames( std::vector<RString> &AddTo ) const; void GetSongGroupNames( std::vector<RString> &AddTo ) const;
bool DoesSongGroupExist( RString sSongGroup ) const; bool DoesSongGroupExist( RString sSongGroup ) const;
bool HasPackIni(RString sSongGroup) const; bool HasPackIni(const RString& sSongGroup) const;
RageColor GetSongGroupColor( const RString &sSongGroupName ) const; RageColor GetSongGroupColor( const RString &sSongGroupName ) const;
RageColor GetSongColor( const Song* pSong ) const; RageColor GetSongColor( const Song* pSong ) const;