better encapsulation

stepmania/src/StepMania.cpp

@@ -1081,11 +1081,7 @@ int main(int argc, char* argv[])
 	/* Set up the theme and announcer, and switch to the last game type. */
 	ReadGamePrefsFromDisk( true );
 
-	{
+	THEME->LoadPreferencesFromMetrics();
-		CString sSection = "Preferences";
-		GetCommandlineArgument( "Type", &sSection );
-		THEME->LoadPreferencesFromSection( sSection );
-	}
 
 	{
 		/* Now that THEME is loaded, load the icon for the current theme into the

stepmania/src/ThemeManager.cpp

@@ -823,8 +823,17 @@ void ThemeManager::GetMetricsThatBeginWith( const CString &sClassName_, const CS
 	}
 }
 
-void ThemeManager::LoadPreferencesFromSection( const CString &sClassName )
+CString ThemeManager::GetPreferencesSection() const
 {
+	CString sSection = "Preferences";
+	GetCommandlineArgument( "Type", &sSection );
+	return sSection;
+}
+
+void ThemeManager::LoadPreferencesFromMetrics()
+{
+	CString sClassName = GetPreferencesSection();
+
 	set<CString> asNames;
 
 	GetMetricsThatBeginWith( sClassName, "", asNames );

stepmania/src/ThemeManager.h

@@ -82,7 +82,8 @@ public:
 	void	GetMetric( const CString &sClassName, const CString &sValueName, apActorCommands &valueOut );
 
 	void GetMetricsThatBeginWith( const CString &sClassName, const CString &sValueName, set<CString> &vsValueNamesOut );
-	void LoadPreferencesFromSection( const CString &sClassName );
+	CString GetPreferencesSection() const;
+	void LoadPreferencesFromMetrics();
 
 	static CString GetBlankGraphicPath();