actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

only set up the popularity contest if we actually need it; it's still a

Browse Source 
little slow
This commit is contained in:
Glenn Maynard
2003-02-22 22:04:44 +00:00
parent edc290583a
commit 763791eb71
1 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/Course.cpp
+21 -16
View File
@@ -305,22 +305,7 @@ void Course::GetStageInfo(
if( m_bRandomize ) if( m_bRandomize )
random_shuffle( entries.begin(), entries.end() ); random_shuffle( entries.begin(), entries.end() );
vector<Song*> vSongsByMostPlayed;
// Sorting is slow, so do this outside the for loop.
vector<Song*> vSongsByMostPlayed = SONGMAN->GetAllSongs();
SortSongPointerArrayByMostPlayed( vSongsByMostPlayed );
// filter out songs that don't have both medium and hard steps and long ver sons
for( int j=vSongsByMostPlayed.size()-1; j>=0; j-- )
{
Song* pSong = vSongsByMostPlayed[j];
if( pSong->m_fMusicLengthSeconds > PREFSMAN->m_fLongVerSongSeconds ||
pSong->m_fMusicLengthSeconds > PREFSMAN->m_fMarathonVerSongSeconds ||
!pSong->GetNotes(nt, DIFFICULTY_MEDIUM) ||
!pSong->GetNotes(nt, DIFFICULTY_HARD) )
vSongsByMostPlayed.erase( vSongsByMostPlayed.begin()+j );
}
for( unsigned i=0; i<entries.size(); i++ ) for( unsigned i=0; i<entries.size(); i++ )
{ {
@@ -380,6 +365,26 @@ void Course::GetStageInfo(
case Entry::players_best: case Entry::players_best:
case Entry::players_worst: case Entry::players_worst:
{ {
if(vSongsByMostPlayed.size() == 0)
{
/* Probably the first time getting here; fill it in just once. */
/* XXX: This is still expensive enough to cause a noticable
* frame drop when scrolling over best/worst entries. */
vSongsByMostPlayed = SONGMAN->GetAllSongs();
SortSongPointerArrayByMostPlayed( vSongsByMostPlayed );
// filter out songs that don't have both medium and hard steps and long ver sons
for( int j=vSongsByMostPlayed.size()-1; j>=0; j-- )
{
Song* pSong = vSongsByMostPlayed[j];
if( pSong->m_fMusicLengthSeconds > PREFSMAN->m_fLongVerSongSeconds ||
pSong->m_fMusicLengthSeconds > PREFSMAN->m_fMarathonVerSongSeconds ||
!pSong->GetNotes(nt, DIFFICULTY_MEDIUM) ||
!pSong->GetNotes(nt, DIFFICULTY_HARD) )
vSongsByMostPlayed.erase( vSongsByMostPlayed.begin()+j );
}
}
if( e.players_index >= (int)vSongsByMostPlayed.size() ) if( e.players_index >= (int)vSongsByMostPlayed.size() )
break; break;