Cleanup RageException::Throw(). Do not use ssprintf() inside of Throw() and do not pass it bare error messages. Use RageException::Throw( "%s", sError.c_str() ); instead. Be consistent with quoting file names "%s" and theme metrics as "%s : %s". Try to make them complete English sentences when possible.
This commit is contained in:
@@ -30,7 +30,7 @@ void ScreenOptionsMaster::Init()
|
||||
vector<RString> asLineNames;
|
||||
split( LINE_NAMES, ",", asLineNames );
|
||||
if( asLineNames.empty() )
|
||||
RageException::Throw( "%s::LineNames is empty.", m_sName.c_str() );
|
||||
RageException::Throw( "\"%s : LineNames\" is empty.", m_sName.c_str() );
|
||||
|
||||
if( FORCE_ALL_PLAYERS )
|
||||
{
|
||||
@@ -59,7 +59,7 @@ void ScreenOptionsMaster::Init()
|
||||
|
||||
OptionRowHandler *pHand = OptionRowHandlerUtil::Make( cmds );
|
||||
if( pHand == NULL )
|
||||
RageException::Throw( "Invalid OptionRowHandler '%s' in %s::Line%i", cmds.GetOriginalCommandString().c_str(), m_sName.c_str(), i );
|
||||
RageException::Throw( "Invalid OptionRowHandler \"%s\" in \"%s : Line%i\".", cmds.GetOriginalCommandString().c_str(), m_sName.c_str(), i );
|
||||
OptionRowHandlers.push_back( pHand );
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user