Cleanup RageException::Throw(). Do not use ssprintf() inside of Throw() and do not pass it bare error messages. Use RageException::Throw( "%s", sError.c_str() ); instead. Be consistent with quoting file names "%s" and theme metrics as "%s : %s". Try to make them complete English sentences when possible.
This commit is contained in:
@@ -45,7 +45,7 @@ void DifficultyIcon::LoadFromNode( const RString& sDir, const XNode* pNode )
|
||||
{
|
||||
RString sFile;
|
||||
if( !pNode->GetAttrValue( "File", sFile ) )
|
||||
RageException::Throw( "MeterDisplay in " + sDir + " missing File attribute" );
|
||||
RageException::Throw( "MeterDisplay in \"%s\" missing \"File\" attribute.", sDir.c_str() );
|
||||
|
||||
LuaHelpers::RunAtExpressionS( sFile );
|
||||
if( !sFile.empty() && sFile[0] != '/' )
|
||||
|
||||
Reference in New Issue
Block a user