cache Trail RadarValues. There needs to be more coordination with Course's Trail cache though.

stepmania/src/Trail.cpp

@@ -51,7 +51,14 @@ bool TrailEntry::ContainsTransformOrTurn() const
 
 RadarValues Trail::GetRadarValues() const
 {
-	RadarValues rv;
+	if( m_bRadarValuesCached )
+	{
+		return m_CachedRadarValues;
+	}
+	else
+	{
+		m_bRadarValuesCached = true;
+		m_CachedRadarValues.Init();
 
 		FOREACH_CONST( TrailEntry, m_vEntries, e )
 		{
@@ -68,17 +75,18 @@ RadarValues Trail::GetRadarValues() const
 				if( po.ContainsTransformOrTurn() )
 					NoteDataUtil::TransformNoteData( nd, po, pSteps->m_StepsType );
 				NoteDataUtil::TransformNoteData( nd, e->Attacks, pSteps->m_StepsType, e->pSong );
-			RadarValues rv2;
+				RadarValues rv;
-			NoteDataUtil::GetRadarValues( nd, e->pSong->m_fMusicLengthSeconds, rv2 );
+				NoteDataUtil::GetRadarValues( nd, e->pSong->m_fMusicLengthSeconds, rv );
-			rv += rv2;
+				m_CachedRadarValues += rv;
 			}
 			else
 			{
-			rv += pSteps->GetRadarValues();			
+				m_CachedRadarValues += pSteps->GetRadarValues();			
 			}
 		}
 
-	return rv;
+		return m_CachedRadarValues;
+	}
 }
 
 int Trail::GetMeter() const

stepmania/src/Trail.h

@@ -45,6 +45,8 @@ public:
 	CourseDifficulty	m_CourseDifficulty;
 	vector<TrailEntry>  m_vEntries;
 	int					m_iSpecifiedMeter;	// == -1 if no meter specified
+	mutable bool		m_bRadarValuesCached;
+	mutable RadarValues	m_CachedRadarValues;
 
 	Trail()
 	{
@@ -56,6 +58,7 @@ public:
 		m_CourseDifficulty = DIFFICULTY_INVALID;
 		m_iSpecifiedMeter = -1;
 		m_vEntries.clear();
+		m_bRadarValuesCached = false;
 	}
 
 	RadarValues GetRadarValues() const;