fix attract music logic

stepmania/src/ScreenAttract.cpp

@@ -108,15 +108,19 @@ void ScreenAttract::AttractInput( const DeviceInput& DeviceI, const InputEventTy
 //	Screen::Input( DeviceI, type, GameI, MenuI, StyleI );
 }
 
+void ScreenAttract::StartPlayingMusic()
+{
+	if( !GAMESTATE->IsTimeToPlayAttractSounds() )
+	{
+		SOUND->PlayMusic( "" ); // stop music
+		return;
+	}
+
+	ScreenWithMenuElements::StartPlayingMusic();
+}
+
 void ScreenAttract::Update( float fDelta )
 {
-	if( IsFirstUpdate() )
-	{
-		if( GAMESTATE->IsTimeToPlayAttractSounds() )
-			SOUND->PlayMusic( THEME->GetPathS(m_sName,"music") );
-		else
-			SOUND->PlayMusic( "" );	// stop music
-	}
 	ScreenWithMenuElements::Update(fDelta);
 }
 
@@ -135,7 +139,7 @@ void ScreenAttract::HandleScreenMessage( const ScreenMessage SM )
 		 * going to interrupt it when we fade in, stop the old music before we fade out. */
 		bool bMusicChanging = false;
 		if( PLAY_MUSIC )
-			bMusicChanging = THEME->GetPathS(NEXT_SCREEN,"music") != THEME->GetPathS(m_sName,"music",true);	// GetPath optional on the next screen because it may not have music.
+			bMusicChanging = THEME->GetPathS(m_sName,"music") != THEME->GetPathS(NEXT_SCREEN,"music",true);	// GetPath optional on the next screen because it may not have music.
 
 		if( bMusicChanging )
 			SOUND->PlayMusic( "" );	// stop the music

stepmania/src/ScreenAttract.h

@@ -19,6 +19,7 @@ public:
 	virtual void HandleScreenMessage( const ScreenMessage SM );
 
 protected:
+	virtual void StartPlayingMusic();
 };
 
 

stepmania/src/ScreenWithMenuElements.cpp

@@ -122,6 +122,14 @@ ScreenWithMenuElements::~ScreenWithMenuElements()
 	SAFE_DELETE( m_textHelp );
 }
 
+void ScreenWithMenuElements::StartPlayingMusic()
+{
+	/* Some screens should leave the music alone (eg. ScreenPlayerOptions music 
+	 * sample left over from ScreenSelectMusic). */
+	if( PLAY_MUSIC )
+		SOUND->PlayMusic( THEME->GetPathS(m_sName,"music") );
+}
+
 void ScreenWithMenuElements::Update( float fDeltaTime )
 {
 	if( m_bFirstUpdate )
@@ -130,10 +138,7 @@ void ScreenWithMenuElements::Update( float fDeltaTime )
 		 * Play sounds after so loading so we don't thrash while loading files. */
 		SOUND->PlayOnceFromDir( ANNOUNCER->GetPathTo(m_sName+" intro") );
 
-		/* Some screens should leave the music alone (eg. ScreenPlayerOptions music 
+		StartPlayingMusic();
-		 * sample left over from ScreenSelectMusic). */
-		if( PLAY_MUSIC )
-			SOUND->PlayMusic( THEME->GetPathS(m_sName,"music") );
 		
 		/* Evaluate FirstUpdateCommand. */
 		this->RunCommands( FIRST_UPDATE_COMMAND );

stepmania/src/ScreenWithMenuElements.h

@@ -29,6 +29,8 @@ public:
 	void ResetTimer();
 
 protected:
+	virtual void StartPlayingMusic();
+
 	AutoActor			m_sprUnderlay;
 	AutoActor			m_autoHeader;
 	Sprite				m_sprStyleIcon;