actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remember to fill in new char's.

Browse Source 
...we seriously need to use a standard <string>.

*glares at Yaniel*
This commit is contained in:
Jason Felds
2015-09-26 21:03:46 -04:00
parent d878a44a9b
commit 537af8d866
5 changed files with 30 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/archutils/Win32/CrashHandlerChild.cpp
+14 -9
View File
@@ -137,9 +137,8 @@ namespace VDDebugInfo
if( dwFileSize == INVALID_FILE_SIZE )
break;
char *buffer = new char[dwFileSize];
if( buffer == NULL )
break;
char *buffer = new char[dwFileSize + 1];
std::fill(buffer, buffer + dwFileSize + 1, '\0' );
DWORD dwActual;
int iRet = ReadFile(h, buffer, dwFileSize, &dwActual, NULL);
@@ -332,7 +331,8 @@ namespace SymbolLookup
return "???";
}
RString sName;
char *buffer = new char[iSize];
char *buffer = new char[iSize + 1];
std::fill(buffer, buffer + iSize + 1, '\0');
if (!ReadFromParent(iFD, buffer, iSize))
{
sName = "???";
@@ -518,7 +518,8 @@ bool ReadCrashDataFromParent( int iFD, CompleteCrashData &Data )
if( !ReadFromParent(iFD, &iSize, sizeof(iSize)) )
return false;
char *buffer = new char[iSize];
char *buffer = new char[iSize + 1];
std::fill(buffer, buffer + iSize + 1, '\0');
bool wasReadSuccessful = ReadFromParent(iFD, buffer, iSize);
RString tmp = buffer;
delete[] buffer;
@@ -532,7 +533,8 @@ bool ReadCrashDataFromParent( int iFD, CompleteCrashData &Data )
if( !ReadFromParent(iFD, &iSize, sizeof(iSize)) )
return false;
buffer = new char[iSize];
buffer = new char[iSize + 1];
std::fill(buffer, buffer + iSize + 1, '\0');
wasReadSuccessful = ReadFromParent(iFD, buffer, iSize);
tmp = buffer;
delete[] buffer;
@@ -550,7 +552,8 @@ bool ReadCrashDataFromParent( int iFD, CompleteCrashData &Data )
{
if( !ReadFromParent(iFD, &iSize, sizeof(iSize)) )
return false;
buffer = new char[iSize];
buffer = new char[iSize + 1];
std::fill(buffer, buffer + iSize + 1, '\0');
wasReadSuccessful = ReadFromParent(iFD, buffer, iSize);
tmp = buffer;
delete[] buffer;
@@ -565,7 +568,8 @@ bool ReadCrashDataFromParent( int iFD, CompleteCrashData &Data )
if( !ReadFromParent(iFD, &iSize, sizeof(iSize)) )
return false;
buffer = new char[iSize];
buffer = new char[iSize + 1];
std::fill(buffer, buffer + iSize + 1, '\0');
wasReadSuccessful = ReadFromParent(iFD, buffer, iSize);
tmp = buffer;
delete[] buffer;
@@ -578,7 +582,8 @@ bool ReadCrashDataFromParent( int iFD, CompleteCrashData &Data )
// 6. Read the crashed thread's name.
if( !ReadFromParent(iFD, &iSize, sizeof(iSize)) )
return false;
buffer = new char[iSize];
buffer = new char[iSize + 1];
std::fill(buffer, buffer + iSize + 1, '\0');
wasReadSuccessful = ReadFromParent(iFD, buffer, iSize);
tmp = buffer;
delete[] buffer;
src/archutils/Win32/CrashHandlerNetworking.cpp
+1
View File
@@ -651,6 +651,7 @@ void NetworkPostData::HttpThread()
{
sBuf.clear();
char * buffer = new char[1024];
std::fill(buffer, buffer + 1024, '\0');
int iGot = m_pStream->Read( static_cast<void *>(buffer), 1024 );
RString tmp = buffer;
delete[] buffer;
src/archutils/Win32/ErrorStrings.cpp
+2 -1
View File
@@ -34,7 +34,8 @@ RString ConvertWstringToCodepage( wstring s, int iCodePage )
NULL, 0, NULL, FALSE );
ASSERT_M( iBytes > 0, werr_ssprintf( GetLastError(), "WideCharToMultiByte" ).c_str() );
char * buf = new char[iBytes];
char * buf = new char[iBytes + 1];
std::fill(buf, buf + iBytes + 1, '\0');
WideCharToMultiByte( CP_ACP, 0, s.data(), s.size(),
buf, iBytes, NULL, FALSE );
RString ret( buf );