From 4dfed451033be98f487de4b8a0aab4b7caa8a5f4 Mon Sep 17 00:00:00 2001 From: Thai Pangsakulyanont Date: Mon, 8 Aug 2011 00:40:14 +0700 Subject: [PATCH] Mute the keysound immediately when letting go of hold note. Don't know if that last formula change is intentional or not, so restoring this old formula. Back this out if it's actually intentional. --- src/Player.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Player.cpp b/src/Player.cpp index 78228bb324..5f0df3e43e 100644 --- a/src/Player.cpp +++ b/src/Player.cpp @@ -1402,8 +1402,7 @@ void Player::UpdateHoldNotes( int iSongRow, float fDeltaTime, vector= 0 && tn.iKeysoundIndex < (int) m_vKeysounds.size() ) { - float factor = (tn.subType == TapNote::hold_head_roll ? 2 : 10.0f - 8.5f); - factor *= fLifeFraction; + float factor = (tn.subType == TapNote::hold_head_roll ? 2.0 * fLifeFraction : 10.0f * fLifeFraction - 8.5f); m_vKeysounds[tn.iKeysoundIndex].SetProperty ("Volume", max(0.0f, min(1.0f, factor))); } }