Enable more compiler warnings and treat them as errors.

2023-02-02 11:54:17 -08:00
parent f8f6f12999
commit 4a6b1a743c
141 changed files with 625 additions and 757 deletions
@@ -152,10 +152,7 @@ void ModIconRow::SetFromGameState()
 	{
 		RString sOption = vsOptions[i];
 		int iPerferredCol = OptionToPreferredColumn( sOption );
-		clamp( iPerferredCol, 0, (int)m_vpModIcon.size()-1 );
-
-		if( iPerferredCol == -1 )
-			continue;	// skip
+		iPerferredCol = clamp( iPerferredCol, 0, (int)m_vpModIcon.size()-1 );

 		// search for a vacant spot
 		for( int j=iPerferredCol; j<NUM_OPTION_ICONS; j++ )