From 469260911abd6544ab9318550b2b0c186411499a Mon Sep 17 00:00:00 2001 From: "Ben \"root\" Anderson" Date: Fri, 25 Oct 2013 17:56:12 -0500 Subject: [PATCH] I dont think theres anything to catch here. GCC doesnt have SEH so skipping the tryblock for now. --- src/archutils/Win32/Crash.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/archutils/Win32/Crash.cpp b/src/archutils/Win32/Crash.cpp index 8f51fd4d85..262bee460e 100644 --- a/src/archutils/Win32/Crash.cpp +++ b/src/archutils/Win32/Crash.cpp @@ -5,6 +5,7 @@ #include +#include "global.h" #include "arch/Threads/Threads_Win32.h" #include "crash.h" #include "CrashHandlerInternal.h" @@ -152,7 +153,8 @@ static const char *CrashGetModuleBaseName(HMODULE hmod, char *pszBaseName) char szPath1[MAX_PATH]; char szPath2[MAX_PATH]; - __try { +// XXX: It looks like nothing in here COULD throw an exception. Need to verify that. +// __try { if( !GetModuleFileName(hmod, szPath1, sizeof(szPath1)) ) return NULL; @@ -173,9 +175,9 @@ static const char *CrashGetModuleBaseName(HMODULE hmod, char *pszBaseName) if( period ) *period = 0; - } __except(1) { - return NULL; - } +// } __except(1) { +// return NULL; +// } return pszBaseName; }