From 3ac6a08fbea4775910c37abb1496125ad5180645 Mon Sep 17 00:00:00 2001
From: Jason Felds <jafelds@gmail.com>
Date: Thu, 2 May 2013 21:44:05 -0400
Subject: [PATCH] Revert "Loop...and const. Crap."

This reverts commit 4979bf3218b96e6eb2016a4b94efc1b1239668c8.
---
 src/ScreenDebugOverlay.cpp | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/src/ScreenDebugOverlay.cpp b/src/ScreenDebugOverlay.cpp
index fd20eb9d7e..87586a152f 100644
--- a/src/ScreenDebugOverlay.cpp
+++ b/src/ScreenDebugOverlay.cpp
@@ -70,7 +70,7 @@ public:
 	virtual RString GetPageName() const { return "Main"; }
 	virtual bool ForceOffAfterUse() const { return false; }
 	virtual bool IsEnabled() const = 0;
-	virtual void DoAndLog( RString &sMessageOut ) const
+	virtual void DoAndLog( RString &sMessageOut )
 	{
 		RString s1 = GetDisplayTitle();
 		RString s2 = GetDisplayValue();
@@ -454,16 +454,15 @@ bool ScreenDebugOverlay::Input( const InputEventPlus &input )
 		return true;
 	}
 
-	// Explicitly be tricky to keep the values aligned.
-	int i = -1;
-	for (IDebugLine const *p : *g_pvpSubscribers)
+	FOREACH_CONST( IDebugLine*, *g_pvpSubscribers, p )
 	{
-		RString sPageName = p->GetPageName();
-		++i;
+		RString sPageName = (*p)->GetPageName();
+
+		int i = p-g_pvpSubscribers->begin();
 
 		// Gameplay buttons are available only in gameplay. Non-gameplay buttons
 		// are only available when the screen is displayed.
-		IDebugLine::Type type = p->GetType();
+		IDebugLine::Type type = (*p)->GetType();
 		switch( type )
 		{
 		case IDebugLine::all_screens:
@@ -480,17 +479,17 @@ bool ScreenDebugOverlay::Input( const InputEventPlus &input )
 			FAIL_M(ssprintf("Invalid debug line type: %i", type));
 		}
 
-		if( input.DeviceI == p->m_Button )
+		if( input.DeviceI == (*p)->m_Button )
 		{
 			if( input.type != IET_FIRST_PRESS )
 				return true; // eat the input but do nothing
 
 			// do the action
 			RString sMessage;
-			p->DoAndLog( sMessage );
+			(*p)->DoAndLog( sMessage );
 			if( !sMessage.empty() )
 				LOG->Trace("DEBUG: %s", sMessage.c_str() );
-			if( p->ForceOffAfterUse() )
+			if( (*p)->ForceOffAfterUse() )
 				m_bForcedHidden = true;
 
 			// update text to show the effect of what changed above