simplify TapAttack storage:

store attack info in TapNote
  in the SMNoteData string, store the attack params inline (like with keysounds)
play keysounds when hit
  still doesn't play keysounds on a miss
  still doesn't play autoKeysounds

stepmania/src/NoteField.cpp

@@ -621,9 +621,8 @@ void NoteField::DrawPrimitives()
 			NoteDisplayCols *nd = CurDisplay->second;
 			if( bIsAttack )
 			{
-				const Attack& attack = GetAttackAt( c, i );
 				Sprite sprite;
-				sprite.Load( THEME->GetPathToG("NoteField attack "+attack.sModifier) );
+				sprite.Load( THEME->GetPathToG("NoteField attack "+tn.sAttackModifiers) );
 				float fBeat = NoteRowToBeat(i);
 				SearchForBeat( CurDisplay, NextDisplay, fBeat );
 				NoteDisplayCols *nd = CurDisplay->second;