actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanups:

Browse Source 
Don't use variables that start with an underscore.  They're reserved
for the system.

Using single-letter variable names is fine for simple for() counters,
but don't use them for real variables.  Here you probably meant
"Coins", "CoinsPerCredit" (const) and "Remainder".

Er, you're implementing div and mod iteratively.  :)
This commit is contained in:
Glenn Maynard
2003-02-12 07:52:20 +00:00
parent aa254bb726
commit 3a13724a70
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/ScreenManager.cpp
+8 -14
View File
@@ -399,20 +399,8 @@ void ScreenManager::RefreshCreditsMessages()
m_textCreditInfo[p].SetDiffuse( CREDITS_COLOR ); m_textCreditInfo[p].SetDiffuse( CREDITS_COLOR );
m_textCreditInfo[p].SetShadowLength( CREDITS_SHADOW_LENGTH ); m_textCreditInfo[p].SetShadowLength( CREDITS_SHADOW_LENGTH );
int _c = GAMESTATE->m_iCoins;
int _x = PREFSMAN->m_iCoinsPerCredit;
LOG->Trace("Actual coins: %d",GAMESTATE->m_iCoins); LOG->Trace("Actual coins: %d",GAMESTATE->m_iCoins);
unsigned int _r = 0;
while (_c >= _x) {
_c -= _x;
_r++;
}
switch( PREFSMAN->m_CoinMode ) switch( PREFSMAN->m_CoinMode )
{ {
case PrefsManager::COIN_HOME: case PrefsManager::COIN_HOME:
@@ -424,8 +412,13 @@ void ScreenManager::RefreshCreditsMessages()
m_textCreditInfo[p].SetText( "NOT PRESENT" ); m_textCreditInfo[p].SetText( "NOT PRESENT" );
break; break;
case PrefsManager::COIN_PAY: case PrefsManager::COIN_PAY:
if (_c == 0) m_textCreditInfo[p].SetText( ssprintf("CREDIT(S) %d ",_r) ); {
else m_textCreditInfo[p].SetText( ssprintf("CREDIT(S) %d (%d / %d)",_r,_c,_x ) ); int Coins = GAMESTATE->m_iCoins % PREFSMAN->m_iCoinsPerCredit;
CString txt = ssprintf("CREDIT(S) %d ", GAMESTATE->m_iCoins / PREFSMAN->m_iCoinsPerCredit);
if (Coins)
txt += ssprintf(" (%d / %d)", Coins, PREFSMAN->m_iCoinsPerCredit );
m_textCreditInfo[p].SetText(txt);
}
break; break;
case PrefsManager::COIN_FREE: case PrefsManager::COIN_FREE:
m_textCreditInfo[p].SetText( "FREE PLAY" ); m_textCreditInfo[p].SetText( "FREE PLAY" );
@@ -435,3 +428,4 @@ void ScreenManager::RefreshCreditsMessages()
} }
} }
} }