cleanup: SetXY in Init, ON_COMMAND in BeginScreen

call base last

stepmania/src/ScreenSelectDifficulty.cpp

@@ -133,8 +133,6 @@ void ScreenSelectDifficulty::Init()
 
 void ScreenSelectDifficulty::BeginScreen()
 {
-	ScreenSelect::BeginScreen();
-
 	for( int page=0; page<NUM_PAGES; page++ )
 	{
 		ON_COMMAND( m_sprExplanation[page] );
@@ -152,6 +150,8 @@ void ScreenSelectDifficulty::BeginScreen()
 		ON_COMMAND( m_sprCursor[p] );
 		ON_COMMAND( m_sprShadow[p] );
 	}
+
+	ScreenSelect::BeginScreen();
 }
 
 void ScreenSelectDifficulty::Update( float fDelta )

stepmania/src/ScreenSelectStyle.cpp

@@ -101,8 +101,6 @@ void ScreenSelectStyle::Init()
 		this->MoveToTail( &m_sprInfo[i] );
 
 
-	this->UpdateSelectableChoices();
-
 	m_sprPremium.SetName( "Premium" );
 
 	switch( GAMESTATE->GetPremium() )
@@ -126,17 +124,36 @@ void ScreenSelectStyle::Init()
 	//
 	for( unsigned i=0; i<m_aGameCommands.size(); i++ )
 	{
-		SET_XY_AND_ON_COMMAND( m_textIcon[i] );
+		SET_XY( m_textIcon[i] );
-		SET_XY_AND_ON_COMMAND( m_sprIcon[i] );
+		SET_XY( m_sprIcon[i] );
 	}
-	SET_XY_AND_ON_COMMAND( m_sprExplanation );
+	SET_XY( m_sprExplanation );
-	SET_XY_AND_ON_COMMAND( m_sprWarning );
+	SET_XY( m_sprWarning );
-	SET_XY_AND_ON_COMMAND( m_sprPremium );
+	SET_XY( m_sprPremium );
 
 	// let AfterChange tween Picture and Info
 	this->SortByDrawOrder();
 }
 
+void ScreenSelectStyle::BeginScreen()
+{
+	this->UpdateSelectableChoices();
+
+	//
+	// TweenOnScreen
+	//
+	for( unsigned i=0; i<m_aGameCommands.size(); i++ )
+	{
+		ON_COMMAND( m_textIcon[i] );
+		ON_COMMAND( m_sprIcon[i] );
+	}
+	ON_COMMAND( m_sprExplanation );
+	ON_COMMAND( m_sprWarning );
+	ON_COMMAND( m_sprPremium );
+
+	ScreenSelect::BeginScreen();
+}
+
 void ScreenSelectStyle::MenuLeft( PlayerNumber pn )
 {
 	int iSwitchToIndex = -1;	// -1 means none found

stepmania/src/ScreenSelectStyle.h

@@ -15,6 +15,7 @@ class ScreenSelectStyle : public ScreenSelect
 public:
 	ScreenSelectStyle( CString sName );
 	virtual void Init();
+	virtual void BeginScreen();
 
 	virtual void MenuLeft( PlayerNumber pn );
 	virtual void MenuRight( PlayerNumber pn );