actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test for error when writing Preferences.ini

Browse Source
This commit is contained in:
Chris Danford
2006-01-20 21:40:15 +00:00
parent 9c540ac8fe
commit 3992801160
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/Themes/default/Languages/en.ini
+2
View File
@@ -1439,3 +1439,5 @@ Open the preferences file to make changes by hand.=Open the preferences file to
StepMania Tools Main Menu=StepMania Tools Main Menu StepMania Tools Main Menu=StepMania Tools Main Menu
Troubleshooting=Troubleshooting Troubleshooting=Troubleshooting
[ChangeGameSettings]
Error writing file '%s': %s=Error writing file '%s': %s
stepmania/src/IniFile.cpp
+3 -1
View File
@@ -80,7 +80,9 @@ bool IniFile::WriteFile( const RString &sPath ) const
return false; return false;
} }
return IniFile::WriteFile( f ); bool bSuccess = IniFile::WriteFile( f );
f.Close();
return bSuccess && !f.GetError().empty();
} }
bool IniFile::WriteFile( RageFileBasic &f ) const bool IniFile::WriteFile( RageFileBasic &f ) const
stepmania/src/smpackage/ChangeGameSettings.cpp
+8 -1
View File
@@ -11,6 +11,8 @@
#include "SpecialFiles.h" #include "SpecialFiles.h"
#include ".\changegamesettings.h" #include ".\changegamesettings.h"
#include "archutils/Win32/DialogUtil.h" #include "archutils/Win32/DialogUtil.h"
#include "LocalizedString.h"
#include "RageUtil.h"
#ifdef _DEBUG #ifdef _DEBUG
#define new DEBUG_NEW #define new DEBUG_NEW
@@ -106,6 +108,7 @@ BOOL ChangeGameSettings::OnInitDialog()
// EXCEPTION: OCX Property Pages should return FALSE // EXCEPTION: OCX Property Pages should return FALSE
} }
static LocalizedString ERROR_WRITING_FILE( "ChangeGameSettings", "Error writing file '%s': %s" );
void ChangeGameSettings::OnOK() void ChangeGameSettings::OnOK()
{ {
// TODO: Add extra validation here // TODO: Add extra validation here
@@ -137,7 +140,11 @@ void ChangeGameSettings::OnOK()
ini.SetValue( "Options", "ShowLogWindow", BST_CHECKED == IsDlgButtonChecked(IDC_CHECK_SHOW_LOG_WINDOW) ); ini.SetValue( "Options", "ShowLogWindow", BST_CHECKED == IsDlgButtonChecked(IDC_CHECK_SHOW_LOG_WINDOW) );
ini.WriteFile( SpecialFiles::PREFERENCES_INI_PATH ); if( !ini.WriteFile(SpecialFiles::PREFERENCES_INI_PATH) )
{
RString sError = ssprintf( ERROR_WRITING_FILE.GetValue(), SpecialFiles::PREFERENCES_INI_PATH.c_str(), ini.GetError().c_str() );
AfxMessageBox( sError );
}
CDialog::OnOK(); CDialog::OnOK();
} }