actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Don't make unnecessary copies.

Browse Source
This commit is contained in:
Steve Checkoway
2006-07-23 21:44:35 +00:00
parent b0496fbcb6
commit 36b1ff3df8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/Player.cpp
+5 -5
View File
@@ -1209,7 +1209,7 @@ void Player::HandleStep( int col, const RageTimer &tm, bool bHeld )
// remove all TapAttacks on this row // remove all TapAttacks on this row
for( int t=0; t<m_NoteData.GetNumTracks(); t++ ) for( int t=0; t<m_NoteData.GetNumTracks(); t++ )
{ {
const TapNote &tn = m_NoteData.GetTapNote(t, iIndexOverlappingNote); const TapNote &tn = m_NoteData.GetTapNote( t, iIndexOverlappingNote );
if( tn.type == TapNote::attack ) if( tn.type == TapNote::attack )
HideNote( t, iIndexOverlappingNote ); HideNote( t, iIndexOverlappingNote );
} }
@@ -1267,7 +1267,7 @@ void Player::HandleStep( int col, const RageTimer &tm, bool bHeld )
iStepSearchRows, MAX_NOTE_ROW, true ); iStepSearchRows, MAX_NOTE_ROW, true );
if( iIndexOverlappingNote != -1 ) if( iIndexOverlappingNote != -1 )
{ {
TapNote tn = m_NoteData.GetTapNote( col, iIndexOverlappingNote ); const TapNote &tn = m_NoteData.GetTapNote( col, iIndexOverlappingNote );
if( tn.bKeysound && tn.iKeysoundIndex < (int) m_vKeysounds.size() ) if( tn.bKeysound && tn.iKeysoundIndex < (int) m_vKeysounds.size() )
m_vKeysounds[tn.iKeysoundIndex].Play(); m_vKeysounds[tn.iKeysoundIndex].Play();
} }
@@ -1460,7 +1460,7 @@ void Player::CrossedRow( int iNoteRow )
{ {
for( int t=0; t<m_NoteData.GetNumTracks(); t++ ) for( int t=0; t<m_NoteData.GetNumTracks(); t++ )
{ {
TapNote tn = m_NoteData.GetTapNote(t, iNoteRow); const TapNote &tn = m_NoteData.GetTapNote( t, iNoteRow );
if( tn.type != TapNote::empty && tn.result.tns == TNS_None ) if( tn.type != TapNote::empty && tn.result.tns == TNS_None )
{ {
Step( t, now ); Step( t, now );
@@ -1510,10 +1510,10 @@ void Player::RandomizeNotes( int iNoteRow )
int iNumOfTracks = m_NoteData.GetNumTracks(); int iNumOfTracks = m_NoteData.GetNumTracks();
for( int t=0; t+1 < iNumOfTracks; t++ ) for( int t=0; t+1 < iNumOfTracks; t++ )
{ {
const int iSwapWith = RandomInt( 0, iNumOfTracks-1 ); const int iSwapWith = RandomInt( iNumOfTracks );
/* Only swap a tap and an empty. */ /* Only swap a tap and an empty. */
const TapNote t1 = m_NoteData.GetTapNote(t, iNewNoteRow); const TapNote t1 = m_NoteData.GetTapNote( t, iNewNoteRow );
if( t1.type != TapNote::tap ) if( t1.type != TapNote::tap )
continue; continue;