actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent access to the root file system via the memorycard mount points

Browse Source 
Before any memorycard is used the mount point exposes "/". Let's
introduce a special value "(empty)" to allow a DIR mount to point to
nothing.
This commit is contained in:
Martin Natano
2022-02-18 17:54:14 +01:00
parent 5322843ace
commit 3216fdec1e
2 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/RageFileDriverDirect.cpp
+20 -1
View File
@@ -99,6 +99,12 @@ static RageFileObjDirect *MakeFileObjDirect( RString sPath, int iMode, int &iErr
RageFileBasic *RageFileDriverDirect::Open( const RString &sPath_, int iMode, int &iError )
{
if( m_sRoot == "(empty)" )
{
iError = (iMode & RageFile::WRITE) ? EROFS : ENOENT;
return nullptr;
}
RString sPath = sPath_;
ASSERT( sPath.size() && sPath[0] == '/' );
@@ -119,6 +125,11 @@ RageFileBasic *RageFileDriverDirect::Open( const RString &sPath_, int iMode, int
bool RageFileDriverDirect::Move( const RString &sOldPath_, const RString &sNewPath_ )
{
if( m_sRoot == "(empty)" )
{
return false;
}
RString sOldPath = sOldPath_;
RString sNewPath = sNewPath_;
FDB->ResolvePath( sOldPath );
@@ -147,6 +158,11 @@ bool RageFileDriverDirect::Move( const RString &sOldPath_, const RString &sNewPa
bool RageFileDriverDirect::Remove( const RString &sPath_ )
{
if( m_sRoot == "(empty)" )
{
return false;
}
RString sPath = sPath_;
FDB->ResolvePath( sPath );
RageFileManager::FileType type = this->GetFileType(sPath);
@@ -199,7 +215,10 @@ bool RageFileDriverDirect::Remount( const RString &sPath )
((DirectFilenameDB *) FDB)->SetRoot( sPath );
/* If the root path doesn't exist, create it. */
CreateDirectories( m_sRoot );
if( m_sRoot != "(empty)" )
{
CreateDirectories( m_sRoot );
}
return true;
}