Add Song::SongHasNoteType, moved from ScreenSelectGroup.

stepmania/src/ScreenSelectGroup.cpp

@@ -78,26 +78,14 @@ ScreenSelectGroup::ScreenSelectGroup()
 	aAllSongs.Copy( SONGMAN->m_pSongs );
 
 	// Filter out Songs that can't be played by the current Style
+	{
 		NotesType nt = GAMESTATE->GetCurrentStyleDef()->m_NotesType;
-
 		for( i=aAllSongs.GetSize()-1; i>=0; i-- )		// foreach Song, back to front
 		{
-		Song* pSong = aAllSongs[i];
+			if( !aAllSongs[i]->SongHasNoteType(nt) )
-
-		bool bSongCanBePlayedByCurrentStyle = false;
-		for( int j=0; j<pSong->m_apNotes.GetSize(); j++ )	// foreach Notes
-		{
-			Notes* pNotes = pSong->m_apNotes[j];
-
-			if( pNotes->m_NotesType == nt )
-			{
-				bSongCanBePlayedByCurrentStyle = true;
-				break;
-			}
-		}
-		if( !bSongCanBePlayedByCurrentStyle )
 				aAllSongs.RemoveAt( i );
 		}
+	}
 
 	// Get group names by thowing them into a hash
 	CMapStringToString mapGroupToNothing;

stepmania/src/Song.cpp

@@ -1212,6 +1212,17 @@ void Song::GetNotesThatMatch( NotesType nt, CArray<Notes*, Notes*>& arrayAddTo )
 			arrayAddTo.Add( m_apNotes[i] );
 }
 
+bool Song::SongHasNoteType( NotesType nt ) const
+{
+	for( int i=0; i < m_apNotes.GetSize(); i++ ) // foreach Notes
+	{
+		if( m_apNotes[i]->m_NotesType == nt )
+			return true;
+	}
+
+	return false;
+}
+
 void Song::SaveToCacheFile()
 {
 	LOG->Trace( "Song::SaveToCacheFile()" );

stepmania/src/song.h

@@ -156,6 +156,7 @@ public:
 	
 	CArray<Notes*, Notes*> m_apNotes;
 
+	bool SongHasNoteType( NotesType nt ) const;
 	void GetNotesThatMatch( NotesType nt, CArray<Notes*, Notes*>& arrayAddTo );
 	int GetNumTimesPlayed()
 	{