From 2cf96dc12ae43dc463587a52f86f27ace1606a35 Mon Sep 17 00:00:00 2001 From: Glenn Maynard Date: Sun, 15 Feb 2004 23:37:31 +0000 Subject: [PATCH] g_CurStageStats isn't meaningful in summary eval cleanup --- stepmania/src/ScreenEvaluation.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/stepmania/src/ScreenEvaluation.cpp b/stepmania/src/ScreenEvaluation.cpp index 9e1b05939b..16f43b9377 100644 --- a/stepmania/src/ScreenEvaluation.cpp +++ b/stepmania/src/ScreenEvaluation.cpp @@ -140,7 +140,7 @@ ScreenEvaluation::ScreenEvaluation( CString sClassName ) : Screen(sClassName) LIGHTSMAN->SetLightMode( LIGHTMODE_MENU ); - m_bFailed = false; // the evaluation is not showing failed results by default + m_bFailed = g_CurStageStats.AllFailed(); ZERO( m_bSavedScreenshot ); @@ -155,17 +155,11 @@ ScreenEvaluation::ScreenEvaluation( CString sClassName ) : Screen(sClassName) else RageException::Throw("Unknown evaluation type \"%s\"", TYPE.c_str() ); - int p; - // // Figure out which statistics and songs we're going to display // StageStats stageStats; - stageStats = g_CurStageStats; - - if(stageStats.AllFailed() ) // if everyone failed - m_bFailed = true; // flag it for this screen vector vSongsToShow; switch( m_Type ) @@ -201,6 +195,7 @@ ScreenEvaluation::ScreenEvaluation( CString sClassName ) : Screen(sClassName) // Calculate grades // Grade grade[NUM_PLAYERS]; + int p; for( p=0; pIsPlayerEnabled(p) ) @@ -982,8 +977,10 @@ void ScreenEvaluation::CommitScores( const StageStats &stageStats, int iPersonal continue; // skip if( iMachineHighScoreIndex[p] == -1 ) // no record continue; // skip - if( m_bFailed ) // both players failed - continue; // skip + /* If we aren't saving scores on fail, it'll be handled above; m_bFailed is only + * meaningful in stage and course eval. */ + // if( m_bFailed ) // both players failed + // continue; // skip for( int p2=0; p2