actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup: instead of

Browse Source 
func
{
  if( x )
  {
   three pages of code
  }
}

do
func
{
  if( !x )
    return;
  three pages of code;
}

which reduces the indentation level and is easier to understand.
This commit is contained in:
Glenn Maynard
2004-11-26 20:36:23 +00:00
parent cf54c6fea7
commit 2c566f6391
1 changed files with 79 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/ScreenPackages.cpp
+5 -5
View File
@@ -572,12 +572,14 @@ void ScreenPackages::EnterURL( const CString & sURL )
} }
void ScreenPackages::HTTPUpdate() void ScreenPackages::HTTPUpdate()
{ {
if ( m_bIsDownloading ) if( !m_bIsDownloading )
{ return;
int BytesGot=0; int BytesGot=0;
//Keep this as a code block //Keep this as a code block
//as there may be need to "if" it out some time. //as there may be need to "if" it out some time.
{ /* If you need a conditional for a large block of code, stick it in
* a function and return. */
int Size = 1; int Size = 1;
while ( Size > 0 ) while ( Size > 0 )
{ {
@@ -663,8 +665,6 @@ void ScreenPackages::HTTPUpdate()
} }
} }
} }
}
}
} }
bool ScreenPackages::ParseHTTPAddress( const CString & URL, CString & Proto, CString & Server, int & Port, CString & Addy ) bool ScreenPackages::ParseHTTPAddress( const CString & URL, CString & Proto, CString & Server, int & Port, CString & Addy )