From 2b73f4b5ec4eba0493cbdf2809bfe41d458d48c4 Mon Sep 17 00:00:00 2001 From: "Ben \"root\" Anderson" Date: Mon, 25 Nov 2013 20:58:04 -0600 Subject: [PATCH] Don't iterate over every StepsType in existence when we already know exactly which StepsTypes we want. --- src/GameManager.cpp | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/GameManager.cpp b/src/GameManager.cpp index 6f335f602c..431d4332ff 100644 --- a/src/GameManager.cpp +++ b/src/GameManager.cpp @@ -2927,19 +2927,11 @@ const Style* GameManager::GetEditorStyleForStepsType( StepsType st ) void GameManager::GetStepsTypesForGame( const Game *pGame, vector& aStepsTypeAddTo ) { - FOREACH_ENUM( StepsType, st ) + for( int i=0; pGame->m_apStyles[i]; ++i ) { - bool found = false; - for( int s=0; pGame->m_apStyles[s]; ++s ) - { - const Style *style = pGame->m_apStyles[s]; - if( style->m_StepsType != st ) - continue; - - found = true; - } - if( found ) - aStepsTypeAddTo.push_back( st ); + const StepsType st = pGame->m_apStyles[i]->m_StepsType; + ASSERT(st < NUM_StepsType); + aStepsTypeAddTo.push_back( st ); } }