When start is pressed or repeated, and we'd normally BeginFadingOut,

we'd set bEndThisScreen to false and continue on.  Instead, if we
were going to set a new screen, but stopped because we're transitioning
or the button was a repeat, just ignore it.  This eliminates an obscure
code path.

stepmania/src/ScreenOptions.cpp

@@ -883,8 +883,9 @@ void ScreenOptions::ProcessMenuStart( const InputEventPlus &input )
 			bEndThisScreen = true;
 
 		/* Don't accept START to go to the next screen if we're still transitioning in. */
-		if( input.type != IET_FIRST_PRESS || IsTransitioning() )
-			bEndThisScreen = false;
+		if( bEndThisScreen &&
+			(input.type != IET_FIRST_PRESS || IsTransitioning()) )
+			return;
 		
 		if( bEndThisScreen )
 		{