actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cat is back in the bag. Revert commits.

Browse Source 
A-mods need to be tested more.

...and this is what happens when you forget to
stash changes before a merge. Lesson learned.
This commit is contained in:
Jason Felds
2013-04-19 21:49:55 -04:00
parent 459ffe027f
commit 20d94d4b7e
7 changed files with 7 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PlayerOptions.cpp
+3 -44
View File
@@ -27,7 +27,6 @@ void PlayerOptions::Init()
{
m_bSetScrollSpeed = false;
m_fMaxScrollBPM = 0; m_SpeedfMaxScrollBPM = 1.0f;
m_fAvgScrollBPM = 0; m_SpeedfAvgScrollBPM = 1.0f;
m_fTimeSpacing = 0; m_SpeedfTimeSpacing = 1.0f;
m_fScrollSpeed = 1.0f; m_SpeedfScrollSpeed = 1.0f;
m_fScrollBPM = 200; m_SpeedfScrollBPM = 1.0f;
@@ -63,7 +62,6 @@ void PlayerOptions::Approach( const PlayerOptions& other, float fDeltaSeconds )
APPROACH( fTimeSpacing );
APPROACH( fScrollSpeed );
//APPROACH( fMaxScrollBPM ); // if uncommented, causes crashes. -aj
//APPROACH( fAvgScrollBPM ); // not sure if this crashes, but playing safe. -Wolfman2000
fapproach( m_fScrollBPM, other.m_fScrollBPM, fDeltaSeconds * other.m_SpeedfScrollBPM*150 );
for( int i=0; i<NUM_ACCELS; i++ )
APPROACH( fAccels[i] );
@@ -120,12 +118,7 @@ void PlayerOptions::GetMods( vector<RString> &AddTo, bool bForceNoteSkin ) const
if( !m_fTimeSpacing )
{
if( m_fAvgScrollBPM )
{
RString s = ssprintf( "a%.0f", m_fAvgScrollBPM );
AddTo.push_back( s );
}
else if( m_fMaxScrollBPM )
if( m_fMaxScrollBPM )
{
RString s = ssprintf( "m%.0f", m_fMaxScrollBPM );
AddTo.push_back( s );
@@ -349,7 +342,6 @@ bool PlayerOptions::FromOneModString( const RString &sOneMod, RString &sErrorOut
SET_FLOAT( fTimeSpacing )
m_fTimeSpacing = 0;
m_fMaxScrollBPM = 0;
m_fAvgScrollBPM = 0;
}
else if( sscanf( sBit, "c%f", &level ) == 1 )
{
@@ -359,7 +351,6 @@ bool PlayerOptions::FromOneModString( const RString &sOneMod, RString &sErrorOut
SET_FLOAT( fTimeSpacing )
m_fTimeSpacing = 1;
m_fMaxScrollBPM = 0;
m_fAvgScrollBPM = 0;
}
// oITG's m-mods
// XXX: will not properly tween, I don't think.
@@ -372,14 +363,6 @@ bool PlayerOptions::FromOneModString( const RString &sOneMod, RString &sErrorOut
*/
SET_FLOAT( fMaxScrollBPM )
m_fTimeSpacing = 0;
m_fAvgScrollBPM = 0;
}
// Third Style inspired a-mods
else if( sscanf( sBit, "a%f", &level ) == 1 )
{
SET_FLOAT( fAvgScrollBPM );
m_fTimeSpacing = 0;
m_fMaxScrollBPM = 0;
}
else if( sBit == "clearall" ) Init();
@@ -683,7 +666,6 @@ bool PlayerOptions::operator==( const PlayerOptions &other ) const
COMPARE(m_fScrollSpeed);
COMPARE(m_fScrollBPM);
COMPARE(m_fMaxScrollBPM);
COMPARE(m_fAvgScrollBPM);
COMPARE(m_fRandomSpeed);
COMPARE(m_FailType);
COMPARE(m_bMuteOnError);
@@ -752,9 +734,9 @@ bool PlayerOptions::IsEasierForSongAndSteps( Song* pSong, Steps* pSteps, PlayerN
if( m_fCover ) return true;
// M-mods and a-mods make songs with indefinite BPMs easier because
// M-mods make songs with indefinite BPMs easier because
// they ensure that the song has a scrollable speed.
if( m_fMaxScrollBPM != 0 || m_fAvgScrollBPM != 0 )
if( m_fMaxScrollBPM != 0 )
{
// BPM display is obfuscated
// if( pSong->m_DisplayBPMType == DISPLAY_BPM_RANDOM )
@@ -848,7 +830,6 @@ RString PlayerOptions::GetSavedPrefsString() const
SAVE( m_fScrollSpeed );
SAVE( m_fScrollBPM );
SAVE( m_fMaxScrollBPM );
SAVE( m_fAvgScrollBPM );
SAVE( m_fScrolls[SCROLL_REVERSE] );
SAVE( m_fPerspectiveTilt );
SAVE( m_bTransforms[TRANSFORM_NOHOLDS] );
@@ -878,7 +859,6 @@ void PlayerOptions::ResetPrefs( ResetPrefsType type )
CPY( m_fScrollSpeed );
CPY( m_fScrollBPM );
CPY( m_fMaxScrollBPM );
CPY( m_fAvgScrollBPM );
break;
case saved_prefs_invalid_for_course:
break;
@@ -953,7 +933,6 @@ public:
p->m_fTimeSpacing = FArg(1);
p->m_fTimeSpacing = 1;
p->m_fMaxScrollBPM = 0;
p->m_fAvgScrollBPM = 0;
return 0;
}
@@ -970,7 +949,6 @@ public:
p->m_fScrollSpeed = FArg(1);
p->m_fTimeSpacing = 0;
p->m_fMaxScrollBPM = 0;
p->m_fAvgScrollBPM = 0;
return 0;
}
@@ -987,23 +965,6 @@ public:
{
p->m_fMaxScrollBPM = FArg(1);
p->m_fTimeSpacing = 0;
p->m_fAvgScrollBPM = 0;
return 0;
}
static int GetAMod( T * p, lua_State * L )
{
if (!p->m_fTimeSpacing && p->m_fAvgScrollBPM)
lua_pushnumber(L, p->m_fAvgScrollBPM);
else
lua_pushnil(L);
return 1;
}
static int SetAMod( T * p, lua_State * L )
{
p->m_fAvgScrollBPM = FArg(1);
p->m_fTimeSpacing = 0;
p->m_fMaxScrollBPM = 0;
return 0;
}
@@ -1224,8 +1185,6 @@ public:
ADD_METHOD( SetXMod );
ADD_METHOD( GetMMod );
ADD_METHOD( SetMMod );
ADD_METHOD( GetAMod );
ADD_METHOD( SetAMod );
// Accel
ADD_METHOD( GetBoost );