War on -Werror, part 12: explicit bool usage.
It may save a few cycles, but it's best to be explicit on boolean operations, especially with ASSERT.
This commit is contained in:
@@ -216,7 +216,7 @@ void ScreenEditMenu::MenuStart( const InputEventPlus & )
|
||||
{
|
||||
case EditMenuAction_Delete:
|
||||
{
|
||||
ASSERT( pSteps );
|
||||
ASSERT( pSteps != NULL );
|
||||
if( pSteps->IsAutogen() )
|
||||
{
|
||||
SCREENMAN->PlayInvalidSound();
|
||||
@@ -234,7 +234,7 @@ void ScreenEditMenu::MenuStart( const InputEventPlus & )
|
||||
case EditMenuAction_Practice:
|
||||
break;
|
||||
case EditMenuAction_Delete:
|
||||
ASSERT( pSteps );
|
||||
ASSERT( pSteps != NULL );
|
||||
ScreenPrompt::Prompt( SM_None, STEPS_WILL_BE_LOST.GetValue() + "\n\n" + CONTINUE_WITH_DELETE.GetValue(),
|
||||
PROMPT_YES_NO, ANSWER_NO );
|
||||
break;
|
||||
@@ -294,7 +294,7 @@ void ScreenEditMenu::MenuStart( const InputEventPlus & )
|
||||
case EditMenuAction_Practice:
|
||||
{
|
||||
// Prepare for ScreenEdit
|
||||
ASSERT( pSteps );
|
||||
ASSERT( pSteps != NULL );
|
||||
bool bPromptToNameSteps = (action == EditMenuAction_Create && dc == Difficulty_Edit);
|
||||
if( bPromptToNameSteps )
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user