War on -Werror, part 12: explicit bool usage.
It may save a few cycles, but it's best to be explicit on boolean operations, especially with ASSERT.
This commit is contained in:
+7
-7
@@ -1383,7 +1383,7 @@ XNode* Profile::SaveSongScoresCreateNode() const
|
||||
CHECKPOINT;
|
||||
|
||||
const Profile* pProfile = this;
|
||||
ASSERT( pProfile );
|
||||
ASSERT( pProfile != NULL );
|
||||
|
||||
XNode* pNode = new XNode( "SongScores" );
|
||||
|
||||
@@ -1464,7 +1464,7 @@ XNode* Profile::SaveCourseScoresCreateNode() const
|
||||
CHECKPOINT;
|
||||
|
||||
const Profile* pProfile = this;
|
||||
ASSERT( pProfile );
|
||||
ASSERT( pProfile != NULL );
|
||||
|
||||
XNode* pNode = new XNode( "CourseScores" );
|
||||
|
||||
@@ -1572,7 +1572,7 @@ XNode* Profile::SaveCategoryScoresCreateNode() const
|
||||
CHECKPOINT;
|
||||
|
||||
const Profile* pProfile = this;
|
||||
ASSERT( pProfile );
|
||||
ASSERT( pProfile != NULL );
|
||||
|
||||
XNode* pNode = new XNode( "CategoryScores" );
|
||||
|
||||
@@ -1644,7 +1644,7 @@ void Profile::LoadCategoryScoresFromNode( const XNode* pCategoryScores )
|
||||
|
||||
void Profile::SaveStatsWebPageToDir( RString sDir ) const
|
||||
{
|
||||
ASSERT( PROFILEMAN );
|
||||
ASSERT( PROFILEMAN != NULL );
|
||||
}
|
||||
|
||||
void Profile::SaveMachinePublicKeyToDir( RString sDir ) const
|
||||
@@ -1680,7 +1680,7 @@ XNode* Profile::SaveScreenshotDataCreateNode() const
|
||||
CHECKPOINT;
|
||||
|
||||
const Profile* pProfile = this;
|
||||
ASSERT( pProfile );
|
||||
ASSERT( pProfile != NULL );
|
||||
|
||||
XNode* pNode = new XNode( "ScreenshotData" );
|
||||
|
||||
@@ -1722,7 +1722,7 @@ XNode* Profile::SaveCalorieDataCreateNode() const
|
||||
CHECKPOINT;
|
||||
|
||||
const Profile* pProfile = this;
|
||||
ASSERT( pProfile );
|
||||
ASSERT( pProfile != NULL );
|
||||
|
||||
XNode* pNode = new XNode( "CalorieData" );
|
||||
|
||||
@@ -1845,7 +1845,7 @@ XNode* Profile::SaveCoinDataCreateNode() const
|
||||
CHECKPOINT;
|
||||
|
||||
const Profile* pProfile = this;
|
||||
ASSERT( pProfile );
|
||||
ASSERT( pProfile != NULL );
|
||||
|
||||
XNode* pNode = new XNode( "CoinData" );
|
||||
|
||||
|
||||
Reference in New Issue
Block a user