actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

War on -Werror, part 12: explicit bool usage.

Browse Source 
It may save a few cycles, but it's best to be
explicit on boolean operations, especially with
ASSERT.
This commit is contained in:
Jason Felds
2012-12-27 11:38:53 -05:00
parent bddbed7e7e
commit 1fc16698ba
46 changed files with 122 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/OptionRowHandler.cpp
+7 -7
View File
@@ -141,7 +141,7 @@ public:
const Command &command = cmds.v[0];
RString sParam = command.GetArg(1).s;
ASSERT( command.m_vsArgs.size() == 2 );
ASSERT( sParam.size() );
ASSERT( sParam.size() != 0 );
m_bUseModNameForIcon = true;
@@ -526,7 +526,7 @@ public:
const Command &command = cmds.v[0];
RString sParam = command.GetArg(1).s;
ASSERT( command.m_vsArgs.size() == 2 );
ASSERT( sParam.size() );
ASSERT( sParam.size() != 0 );
if( sParam == "EditSteps" )
{
@@ -707,7 +707,7 @@ class OptionRowHandlerListStyles: public OptionRowHandlerList
vector<const Style*> vStyles;
GAMEMAN->GetStylesForGame( GAMESTATE->m_pCurGame, vStyles );
ASSERT( vStyles.size() );
ASSERT( vStyles.size() != 0 );
FOREACH_CONST( const Style*, vStyles, s )
{
m_Def.m_vsChoices.push_back( GAMEMAN->StyleToLocalizedString(*s) );
@@ -731,7 +731,7 @@ class OptionRowHandlerListGroups: public OptionRowHandlerList
vector<RString> vSongGroups;
SONGMAN->GetSongGroupNames( vSongGroups );
ASSERT( vSongGroups.size() );
ASSERT( vSongGroups.size() != 0 );
{
m_Def.m_vsChoices.push_back( "AllGroups" );
@@ -861,7 +861,7 @@ public:
const Command &command = cmds.v[0];
ASSERT( command.m_vsArgs.size() == 2 );
RString sLuaFunction = command.m_vsArgs[1];
ASSERT( sLuaFunction.size() );
ASSERT( sLuaFunction.size() != 0 );
m_Def.m_bAllowThemeItems = false; // Lua options are always dynamic and can theme themselves.
@@ -1115,7 +1115,7 @@ public:
const Command &command = cmds.v[0];
RString sParam = command.GetArg(1).s;
ASSERT( command.m_vsArgs.size() == 2 );
ASSERT( sParam.size() );
ASSERT( sParam.size() != 0 );
Init();
@@ -1199,7 +1199,7 @@ public:
const Command &command = cmds.v[0];
RString sParam = command.GetArg(1).s;
ASSERT( command.m_vsArgs.size() == 2 );
ASSERT( sParam.size() );
ASSERT( sParam.size() != 0 );
if( sParam == "EditStepsType" )
{