actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

freaky-deaky outside debugger-only crash in NoteData. Why didn't VC7 catch use of an uninitialized variable?!?

Browse Source
This commit is contained in:
Chris Danford
2003-02-10 07:38:12 +00:00
parent 538081f804
commit 1438af64a1
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/NoteData.cpp
+2 -1
View File
@@ -21,6 +21,7 @@
#include "GameState.h" #include "GameState.h"
#include "math.h" #include "math.h"
#include "NotesLoaderSM.h" #include "NotesLoaderSM.h"
#include "RageLog.h"
NoteData::NoteData() NoteData::NoteData()
@@ -30,8 +31,8 @@ NoteData::NoteData()
void NoteData::Init() void NoteData::Init()
{ {
m_iNumTracks = 0; // must do this before calling ClearAll()!
ClearAll(); ClearAll();
m_iNumTracks = 0;
} }
NoteData::~NoteData() NoteData::~NoteData()
stepmania/src/Song.cpp
+3 -1
View File
@@ -413,7 +413,7 @@ void Song::TidyUpData()
else // ! HasMusic() else // ! HasMusic()
{ {
m_fMusicLengthSeconds = 100; // guess m_fMusicLengthSeconds = 100; // guess
LOG->Warn("File %s has no music; guessing at %f seconds", m_fMusicLengthSeconds); LOG->Warn("This song has no music file; guessing at %f seconds", m_fMusicLengthSeconds);
} }
/* Generate these before we autogen notes, so the new notes can inherit /* Generate these before we autogen notes, so the new notes can inherit
@@ -446,6 +446,8 @@ void Song::TidyUpData()
// image is the banner, which is the background, and which is the CDTitle. // image is the banner, which is the background, and which is the CDTitle.
// //
LOG->Trace("Looking for images...");
// //
// First, check the file name for hints. // First, check the file name for hints.
// //
stepmania/stepmania.nsi
+3 -3
View File
@@ -19,7 +19,7 @@
!define PRODUCT_NAME_VER "${PRODUCT_NAME} ${VERSION}" !define PRODUCT_NAME_VER "${PRODUCT_NAME} ${VERSION}"
Name "${PRODUCT_NAME}" Name "${PRODUCT_NAME}"
OutFile "stepmania-CVS-20030207.exe" OutFile "stepmania-CVS-20030209.exe"
;OutFile "stepmania301.exe" ;OutFile "stepmania301.exe"
; Some default compiler settings (uncomment and change at will): ; Some default compiler settings (uncomment and change at will):
@@ -145,7 +145,7 @@ File /r "NoteSkins\dance\note"
SetOutPath "$INSTDIR\NoteSkins\pump" SetOutPath "$INSTDIR\NoteSkins\pump"
File /r "NoteSkins\pump\classic" ; what the heck, they're tiny File /r "NoteSkins\pump\classic" ; what the heck, they're tiny
File /r "NoteSkins\pump\shiny" ;File /r "NoteSkins\pump\shiny" ; not in CVS anymore? -Chris
SetOutPath "$INSTDIR\NoteSkins\ez2" SetOutPath "$INSTDIR\NoteSkins\ez2"
File /r "NoteSkins\ez2\original" File /r "NoteSkins\ez2\original"
@@ -265,7 +265,7 @@ RMDir /r "$INSTDIR\NoteSkins\dance\flat"
RMDir /r "$INSTDIR\NoteSkins\dance\note" RMDir /r "$INSTDIR\NoteSkins\dance\note"
RMDir "$INSTDIR\NoteSkins\dance" RMDir "$INSTDIR\NoteSkins\dance"
RMDir /r "$INSTDIR\NoteSkins\pump\classic" RMDir /r "$INSTDIR\NoteSkins\pump\classic"
RMDir /r "$INSTDIR\NoteSkins\pump\shiny" ;RMDir /r "$INSTDIR\NoteSkins\pump\shiny" ; not in CVS anymore? -Chris
RMDir "$INSTDIR\NoteSkins\pump" RMDir "$INSTDIR\NoteSkins\pump"
RMDir /r "$INSTDIR\NoteSkins\ez2\original" RMDir /r "$INSTDIR\NoteSkins\ez2\original"
RMDir "$INSTDIR\NoteSkins\ez2" RMDir "$INSTDIR\NoteSkins\ez2"