actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Comment.

Browse Source 
Too many variables declared in one place; scope them better.
This commit is contained in:
Glenn Maynard
2003-09-19 20:07:58 +00:00
parent 72e230dbb4
commit 12e5f297ab
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/Player.cpp
+7 -2
View File
@@ -663,6 +663,8 @@ void PlayerMinus::OnRowCompletelyJudged( int iIndexThatWasSteppedOn )
* function is only called when a row is completed. */ * function is only called when a row is completed. */
/* Instead, use the last tap score (ala DDR). Using the minimum results in /* Instead, use the last tap score (ala DDR). Using the minimum results in
* slightly more harsh scoring than DDR */ * slightly more harsh scoring than DDR */
/* I'm not sure this is right, either. Can you really jump a boo and a perfect
* and get scored for a perfect? (That's so loose, you can gallop jumps.) -glenn */
// TapNoteScore score = MinTapNoteScore(iIndexThatWasSteppedOn); // TapNoteScore score = MinTapNoteScore(iIndexThatWasSteppedOn);
TapNoteScore score = LastTapNoteScore(iIndexThatWasSteppedOn); TapNoteScore score = LastTapNoteScore(iIndexThatWasSteppedOn);
ASSERT(score != TNS_NONE); ASSERT(score != TNS_NONE);
@@ -711,13 +713,15 @@ void PlayerMinus::OnRowCompletelyJudged( int iIndexThatWasSteppedOn )
void PlayerMinus::UpdateTapNotesMissedOlderThan( float fMissIfOlderThanSeconds ) void PlayerMinus::UpdateTapNotesMissedOlderThan( float fMissIfOlderThanSeconds )
{ {
//LOG->Trace( "Steps::UpdateTapNotesMissedOlderThan(%f)", fMissIfOlderThanThisBeat ); //LOG->Trace( "Steps::UpdateTapNotesMissedOlderThan(%f)", fMissIfOlderThanThisBeat );
int iMissIfOlderThanThisIndex;
{
const float fEarliestTime = GAMESTATE->m_fMusicSeconds - fMissIfOlderThanSeconds; const float fEarliestTime = GAMESTATE->m_fMusicSeconds - fMissIfOlderThanSeconds;
bool bFreeze; bool bFreeze;
float fMissIfOlderThanThisBeat; float fMissIfOlderThanThisBeat;
float fThrowAway; float fThrowAway;
GAMESTATE->m_pCurSong->GetBeatAndBPSFromElapsedTime( fEarliestTime, fMissIfOlderThanThisBeat, fThrowAway, bFreeze ); GAMESTATE->m_pCurSong->GetBeatAndBPSFromElapsedTime( fEarliestTime, fMissIfOlderThanThisBeat, fThrowAway, bFreeze );
int iMissIfOlderThanThisIndex = BeatToNoteRow( fMissIfOlderThanThisBeat ); iMissIfOlderThanThisIndex = BeatToNoteRow( fMissIfOlderThanThisBeat );
if( bFreeze ) if( bFreeze )
{ {
/* iMissIfOlderThanThisIndex is a freeze. Include the index of the freeze, /* iMissIfOlderThanThisIndex is a freeze. Include the index of the freeze,
@@ -725,10 +729,11 @@ void PlayerMinus::UpdateTapNotesMissedOlderThan( float fMissIfOlderThanSeconds )
* freeze finishes. */ * freeze finishes. */
iMissIfOlderThanThisIndex++; iMissIfOlderThanThisIndex++;
} }
}
// Since this is being called every frame, let's not check the whole array every time. // Since this is being called every frame, let's not check the whole array every time.
// Instead, only check 10 elements back. Even 10 is overkill. // Instead, only check 10 elements back. Even 10 is overkill.
int iStartCheckingAt = max( 0, iMissIfOlderThanThisIndex-10 ); const int iStartCheckingAt = max( 0, iMissIfOlderThanThisIndex-10 );
//LOG->Trace( "iStartCheckingAt: %d iMissIfOlderThanThisIndex: %d", iStartCheckingAt, iMissIfOlderThanThisIndex ); //LOG->Trace( "iStartCheckingAt: %d iMissIfOlderThanThisIndex: %d", iStartCheckingAt, iMissIfOlderThanThisIndex );