From 0c83062440dd390423462b80e10eee70aa093b1f Mon Sep 17 00:00:00 2001 From: Steve Checkoway Date: Fri, 26 Dec 2008 11:46:47 +0000 Subject: [PATCH] Fix warnings about untested return value for system and nonconstant format string with no arguments for Throw. --- stepmania/src/arch/ArchHooks/ArchHooks_Unix.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/stepmania/src/arch/ArchHooks/ArchHooks_Unix.cpp b/stepmania/src/arch/ArchHooks/ArchHooks_Unix.cpp index 040b485629..eb4fbd3d08 100644 --- a/stepmania/src/arch/ArchHooks/ArchHooks_Unix.cpp +++ b/stepmania/src/arch/ArchHooks/ArchHooks_Unix.cpp @@ -232,9 +232,13 @@ void ArchHooks_Unix::SetTime( tm newtime ) newtime.tm_sec ); LOG->Trace( "executing '%s'", sCommand.c_str() ); - system( sCommand ); + int ret = system( sCommand ); + if( ret == -1 || ret == 127 || !WIFEXITED(ret) || WEXITSTATUS(ret) ) + LOG->Trace( "'%s' failed", sCommand.c_str() ); - system( "hwclock --systohc" ); + ret = system( "hwclock --systohc" ); + if( ret == -1 || ret == 127 || !WIFEXITED(ret) || WEXITSTATUS(ret) ) + LOG->Trace( "'hwclock --systohc' failed" ); } #include "RageFileManager.h" @@ -276,7 +280,7 @@ void ArchHooks::MountInitialFilesystems( const RString &sDirOfExecutable ) else if( !stat(RageFileManagerUtil::sInitialWorkingDirectory + "/Songs", &st) && st.st_mode&S_IFDIR ) Root = RageFileManagerUtil::sInitialWorkingDirectory; else - RageException::Throw( COULDNT_FIND_SONGS.GetValue() ); + RageException::Throw( "%s", COULDNT_FIND_SONGS.GetValue().c_str() ); FILEMAN->Mount( "dir", Root, "/" ); }