This commit is contained in:
Glenn Maynard
2004-11-13 21:07:10 +00:00
parent 2a92bc832a
commit 07fd0101dc
+10 -11
View File
@@ -889,19 +889,18 @@ bool BMSLoader::LoadFromDir( CString sDir, Song &out )
{ {
for( unsigned i=0; i < aBMSData.size(); i++ ) for( unsigned i=0; i < aBMSData.size(); i++ )
{ {
CString sTitle; // Declare here for less memory thrashing CString sTitle;
if( GetTagFromMap( aBMSData[i], "#title", sTitle ) ) if( !GetTagFromMap( aBMSData[i], "#title", sTitle ) )
continue;
commonSubstring = FindLargestCommonSubstring( commonSubstring, sTitle );
if( commonSubstring == "" )
{ {
commonSubstring = FindLargestCommonSubstring( commonSubstring, sTitle ); // All bets are off; the titles don't match at all.
if( commonSubstring == "" ) // At this rate we're lucky if we even get the title right.
{ LOG->Warn("BMS files in %s have inconsistent titles", sDir.c_str() );
// All bets are off; the titles don't match at all. break;
// At this rate we're lucky if we even get the title right.
LOG->Warn("BMS files in %s have inconsistent titles", sDir.c_str() );
break;
}
} }
// else no comparison, this file is missing a #title tag.
} }
} }
// Yay, we have our substring. (something like "LION SUKI") // Yay, we have our substring. (something like "LION SUKI")