actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed a lot of memory leaks caused by static globals never getting

Browse Source 
deleted and some other objects not getting deleted properly due to missing
destructors.
This commit is contained in:
Shenjoku
2013-04-18 21:17:57 -07:00
parent 5f7001ef0a
commit 01456ed0b9
29 changed files with 239 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Preference.cpp
+12 -8
View File
@@ -7,23 +7,27 @@
#include "SubscriptionManager.h"
#include "Foreach.h"
static SubscriptionManager<IPreference> m_Subscribers;
SubscriptionManager<IPreference> & GetSubscribers()
{
static SubscriptionManager<IPreference> subscribers;
return subscribers;
}
IPreference::IPreference( const RString& sName ):
m_sName( sName ),
m_bIsStatic( false )
{
m_Subscribers.Subscribe( this );
GetSubscribers().Subscribe( this );
}
IPreference::~IPreference()
{
m_Subscribers.Unsubscribe( this );
GetSubscribers().Unsubscribe( this );
}
IPreference *IPreference::GetPreferenceByName( const RString &sName )
{
FOREACHS( IPreference*, *m_Subscribers.m_pSubscribers, p )
FOREACHS( IPreference*, GetSubscribers().m_pSubscribers, p )
{
if( !(*p)->GetName().CompareNoCase( sName ) )
return *p;
@@ -34,20 +38,20 @@ IPreference *IPreference::GetPreferenceByName( const RString &sName )
void IPreference::LoadAllDefaults()
{
FOREACHS_CONST( IPreference*, *m_Subscribers.m_pSubscribers, p )
FOREACHS_CONST( IPreference*, GetSubscribers().m_pSubscribers, p )
(*p)->LoadDefault();
}
void IPreference::ReadAllPrefsFromNode( const XNode* pNode, bool bIsStatic )
{
ASSERT( pNode != NULL );
FOREACHS_CONST( IPreference*, *m_Subscribers.m_pSubscribers, p )
FOREACHS_CONST( IPreference*, GetSubscribers().m_pSubscribers, p )
(*p)->ReadFrom( pNode, bIsStatic );
}
void IPreference::SavePrefsToNode( XNode* pNode )
{
FOREACHS_CONST( IPreference*, *m_Subscribers.m_pSubscribers, p )
FOREACHS_CONST( IPreference*, GetSubscribers().m_pSubscribers, p )
(*p)->WriteTo( pNode );
}
@@ -55,7 +59,7 @@ void IPreference::ReadAllDefaultsFromNode( const XNode* pNode )
{
if( pNode == NULL )
return;
FOREACHS_CONST( IPreference*, *m_Subscribers.m_pSubscribers, p )
FOREACHS_CONST( IPreference*, GetSubscribers().m_pSubscribers, p )
(*p)->ReadDefaultFrom( pNode );
}