From 40bdb2d5474c3afb5fe725f8ae9f7f9f81bd742e Mon Sep 17 00:00:00 2001 From: Luke Engle Date: Tue, 20 Sep 2022 13:26:17 -0700 Subject: [PATCH] Circle edits --- circle_ci/1-configure.md | 4 +--- circle_ci/2-audit.md | 2 +- circle_ci/3-forecast.md | 2 +- circle_ci/5-custom-transformers.md | 6 +++--- circle_ci/6-migrate.md | 1 - 5 files changed, 6 insertions(+), 9 deletions(-) diff --git a/circle_ci/1-configure.md b/circle_ci/1-configure.md index 16c05de..45ff5b3 100644 --- a/circle_ci/1-configure.md +++ b/circle_ci/1-configure.md @@ -29,8 +29,6 @@ You will need to complete all of the setup instructions [here](./readme.md#confi - At the CircleCI token prompt, enter the CircleCI access token from step 2 and press enter. - At the CircleCI base url prompt, hit enter to accept the default value (`https://circleci.com`). - At the CircleCI organization name prompt, enter `valet-labs`. This is the organization we'll be using throughout these labs. - - At the access token to fetch source code in GitHub prompt, enter the GitHub PAT generated in step 1 and press enter. - - At the GitHub instance url containing source code prompt, press enter to accept the default value (`https://github.com`). ```console $ gh valet configure @@ -59,7 +57,7 @@ To verify our environment is configured correctly, we are going to run the `upda 2. You should see a confirmation that you were logged into the GitHub Container Registry and Valet was updated to the latest version. ```console - $ gh valet version + $ gh valet update Login Succeeded latest: Pulling from valet-customers/valet-cli Digest: sha256:a7d00dee8a37e25da59daeed44b1543f476b00fa2c41c47f48deeaf34a215bbb diff --git a/circle_ci/2-audit.md b/circle_ci/2-audit.md index 1e954ef..30e842b 100644 --- a/circle_ci/2-audit.md +++ b/circle_ci/2-audit.md @@ -34,7 +34,7 @@ You will be performing an `audit` for the __valet-labs__ CircleCI organization t 1. Find the `audit_summary.md` file in the file explorer. 2. Right-click the `audit_summary.md` file and select `Open Preview`. -3. This file contains details that summarizes what percentage of your pipelines were converted automatically. +3. This file contains details that summarize what percentage of your pipelines were converted automatically. ### Review audit summary diff --git a/circle_ci/3-forecast.md b/circle_ci/3-forecast.md index a798adc..a4f5c53 100644 --- a/circle_ci/3-forecast.md +++ b/circle_ci/3-forecast.md @@ -12,7 +12,7 @@ In this lab you will use the `forecast` command to forecast potential GitHub Act Answer the following questions before running the `forecast` command: 1. What is the date you want to start forecasting from? - - **2022-09-02**. This date is needed as it is prior to when the bulk of builds were trigger in the demo CircleCI organization for these labs. This value defaults to the date one week ago, however, you should use a start date that will show a representative view of typical usage. + - **2022-09-02**. This date is needed as it is prior to when the bulk of builds were triggered in the demo CircleCI organization for these labs. This value defaults to the date one week ago, however, you should use a start date that will show a representative view of typical usage. 2. Where do you want to store the results? - **tmp/forecast_reports** diff --git a/circle_ci/5-custom-transformers.md b/circle_ci/5-custom-transformers.md index 04a7d05..21523a4 100644 --- a/circle_ci/5-custom-transformers.md +++ b/circle_ci/5-custom-transformers.md @@ -64,7 +64,7 @@ _Note_: You can refer to the previous [lab](./4-dry-run.md) to learn about the f ## Custom transformers for an unknown step -The converted workflow above contains an `codecov_codecov_upload` step that was not automatically converted. Answer the following questions before writing a custom transformer: +The converted workflow above contains a `codecov_codecov_upload` step that was not automatically converted. Answer the following questions before writing a custom transformer: 1. What is the "identifier" of the step to customize? - __codecov_codecov_upload__ @@ -127,7 +127,7 @@ end ## Custom transformers for environment variables -You can use custom transformers to edit the values of environment variables in converted workflows. In this example, you will update the `COVERAGE_DIR` environment variable to be `$RUNNER_TEMP/cov` instead of `tmp/cov`. +You can use custom transformers to edit the values of environment variables in converted workflows. In this example, you will update the `COVERAGE_DIR` environment variable to be `$RUNNER_TEMP/cov` instead of `./tmp/cov`. To do this, add the following code to the `transformers.rb` file. @@ -191,7 +191,7 @@ That's it! Congratulations, you have overridden Valet's default behavior by cust - Unknown steps - Environment variables -- Runner +- Runners ## Next lab diff --git a/circle_ci/6-migrate.md b/circle_ci/6-migrate.md index ee136a9..915e6bc 100644 --- a/circle_ci/6-migrate.md +++ b/circle_ci/6-migrate.md @@ -7,7 +7,6 @@ In this lab, you will use the `migrate` command to convert a CircleCI pipeline a 1. Followed the steps [here](./readme.md#configure-your-codespace) to set up your GitHub Codespaces environment. 2. Completed the [configure lab](./1-configure.md#configuring-credentials). 3. Completed the [dry-run lab](./4-dry-run.md). -4. Completed the [custom transformers lab](./5-custom-transformers.md). ## Performing a migration