Compare commits
121
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
88502badc9 | ||
|
|
ff7c97a976 | ||
|
|
4d3b8e5269 | ||
|
|
38ee6e8360 | ||
|
|
54cd9a7cba | ||
|
|
c4693c00ac | ||
|
|
e89f113be2 | ||
|
|
2b96ea7f03 | ||
|
|
4300ce8d38 | ||
|
|
de48c615a3 | ||
|
|
eef7e39202 | ||
|
|
37dc32836b | ||
|
|
890361387d | ||
|
|
61f19e6447 | ||
|
|
fd959624bf | ||
|
|
11dd186eb0 | ||
|
|
1ab05cf855 | ||
|
|
7d7d5e7c84 | ||
|
|
8a8fa8bd07 | ||
|
|
06daf8e801 | ||
|
|
aeb9ff5438 | ||
|
|
1ef21ab130 | ||
|
|
3c95902dd6 | ||
|
|
4b4ec08f7b | ||
|
|
a91c3ac205 | ||
|
|
bf0cb7fac4 | ||
|
|
07a7056819 | ||
|
|
b93fcee7ff | ||
|
|
8bac022bfd | ||
|
|
fc4fb55b25 | ||
|
|
31c132fdca | ||
|
|
10bc05df70 | ||
|
|
e641ee9a41 | ||
|
|
0ba71661e5 | ||
|
|
8ef181b2cb | ||
|
|
7e2a489d03 | ||
|
|
eaeaeb3d57 | ||
|
|
1eaf30e6eb | ||
|
|
5da3462152 | ||
|
|
6fa5a8f9c0 | ||
|
|
0d23c39a5d | ||
|
|
6549b27685 | ||
|
|
f4b16c52e5 | ||
|
|
1a7a37c468 | ||
|
|
38b459efad | ||
|
|
6410b2cdd2 | ||
|
|
fd3a3b1051 | ||
|
|
6771e49f11 | ||
|
|
c7c07e1117 | ||
|
|
59fdb0cce7 | ||
|
|
950228f7f7 | ||
|
|
6973819203 | ||
|
|
eee2e3260e | ||
|
|
7eeddef885 | ||
|
|
8c58cdad09 | ||
|
|
380290a89b | ||
|
|
50c3ed0ba6 | ||
|
|
0455501026 | ||
|
|
bac3f038ac | ||
|
|
2d81062605 | ||
|
|
2ae4b932b7 | ||
|
|
c7d4075ae0 | ||
|
|
49a0208abf | ||
|
|
94941958fb | ||
|
|
2764e60363 | ||
|
|
bcd1b9ab86 | ||
|
|
d96759fedc | ||
|
|
bfd72e7da2 | ||
|
|
d8efcf0c1f | ||
|
|
3b74514266 | ||
|
|
6dfe5fd567 | ||
|
|
71a0ed0a31 | ||
|
|
7a364ecd6b | ||
|
|
435083feb7 | ||
|
|
781a55eaaa | ||
|
|
335c64c139 | ||
|
|
af9a4fa160 | ||
|
|
3e04d4bc87 | ||
|
|
be076ebeca | ||
|
|
b74c52c335 | ||
|
|
2233eb2b88 | ||
|
|
ca11176434 | ||
|
|
c8f5c5518e | ||
|
|
469156603d | ||
|
|
6b1d7e7207 | ||
|
|
a57a1dd454 | ||
|
|
0e8bd1f46f | ||
|
|
dd931c7005 | ||
|
|
d8d78b6ace | ||
|
|
a1eafc653a | ||
|
|
35b0f5ded9 | ||
|
|
5a25f0b1b3 | ||
|
|
88dd76a7ef | ||
|
|
b1427bfe58 | ||
|
|
0d079c6553 | ||
|
|
ce3b0c8116 | ||
|
|
d01dd09c36 | ||
|
|
21d1a080df | ||
|
|
c869fcfa38 | ||
|
|
20229aad71 | ||
|
|
65d6c26087 | ||
|
|
8b6795d89d | ||
|
|
030c97ab49 | ||
|
|
dc44a85a96 | ||
|
|
9cdfbb83fa | ||
|
|
b1f8412445 | ||
|
|
0d02efb12c | ||
|
|
2a09e52261 | ||
|
|
e86dfd8cc0 | ||
|
|
a39d9063b3 | ||
|
|
9809e06c2d | ||
|
|
70bbe4186e | ||
|
|
23d1ffffb6 | ||
|
|
d792f3e8ca | ||
|
|
5da7945e2b | ||
|
|
a8e7c378a3 | ||
|
|
0e0d6ec5d6 | ||
|
|
47f663b6ee | ||
|
|
dfcdb87cb3 | ||
|
|
79f5aede88 | ||
|
|
aef949f026 |
@@ -0,0 +1 @@
|
|||||||
|
fail-on-severity: low
|
||||||
+2
-1
@@ -75,6 +75,7 @@ Here are a few things you can do that will increase the likelihood of your pull
|
|||||||
|
|
||||||
## Cutting a new release
|
## Cutting a new release
|
||||||
|
|
||||||
|
1. Update the version number in [package.json](https://github.com/actions/dependency-review-action/blob/main/package.json).
|
||||||
1. Go to [Draft a new
|
1. Go to [Draft a new
|
||||||
release](https://github.com/actions/dependency-review-action/releases/new)
|
release](https://github.com/actions/dependency-review-action/releases/new)
|
||||||
in the Releases page.
|
in the Releases page.
|
||||||
@@ -100,7 +101,7 @@ major version number (e.g. `v1`) in their workflows while
|
|||||||
automatically getting all the
|
automatically getting all the
|
||||||
minor/patch updates.
|
minor/patch updates.
|
||||||
|
|
||||||
To do this just force-create a new annotated tag and push it:
|
To do this just checkout `main`, force-create a new annotated tag, and push it:
|
||||||
```
|
```
|
||||||
git tag -fa v2 -m "Updating v2 to 2.3.4"
|
git tag -fa v2 -m "Updating v2 to 2.3.4"
|
||||||
git push origin v2 --force
|
git push origin v2 --force
|
||||||
|
|||||||
@@ -5,8 +5,14 @@ raise an error if any vulnerabilities or invalid licenses are being introduced.
|
|||||||
|
|
||||||
The action is available for all public repositories, as well as private repositories that have GitHub Advanced Security licensed.
|
The action is available for all public repositories, as well as private repositories that have GitHub Advanced Security licensed.
|
||||||
|
|
||||||
|
You can see the results on the job logs
|
||||||
|
|
||||||
<img width="854" alt="Screen Shot 2022-03-31 at 1 10 51 PM" src="https://user-images.githubusercontent.com/2161/161042286-b22d7dd3-13cb-458d-8744-ce70ed9bf562.png">
|
<img width="854" alt="Screen Shot 2022-03-31 at 1 10 51 PM" src="https://user-images.githubusercontent.com/2161/161042286-b22d7dd3-13cb-458d-8744-ce70ed9bf562.png">
|
||||||
|
|
||||||
|
or on the job summary
|
||||||
|
|
||||||
|
<img src="https://user-images.githubusercontent.com/7847935/182871416-50332bbb-b279-4621-a136-ca72a4314301.png">
|
||||||
|
|
||||||
## Installation
|
## Installation
|
||||||
|
|
||||||
**Please keep in mind that you need a [GitHub Advanced Security](https://docs.github.com/en/enterprise-cloud@latest/get-started/learning-about-github/about-github-advanced-security) license if you're running this action on private repositories.**
|
**Please keep in mind that you need a [GitHub Advanced Security](https://docs.github.com/en/enterprise-cloud@latest/get-started/learning-about-github/about-github-advanced-security) license if you're running this action on private repositories.**
|
||||||
@@ -32,7 +38,7 @@ jobs:
|
|||||||
|
|
||||||
### GitHub Enterprise Server
|
### GitHub Enterprise Server
|
||||||
|
|
||||||
This action is available in GHES starting with version 3.6. Make sure
|
This action is available in Enterprise Server starting with version 3.6. Make sure
|
||||||
[GitHub Advanced
|
[GitHub Advanced
|
||||||
Security](https://docs.github.com/en/[email protected]/admin/code-security/managing-github-advanced-security-for-your-enterprise/enabling-github-advanced-security-for-your-enterprise)
|
Security](https://docs.github.com/en/[email protected]/admin/code-security/managing-github-advanced-security-for-your-enterprise/enabling-github-advanced-security-for-your-enterprise)
|
||||||
and [GitHub
|
and [GitHub
|
||||||
@@ -44,7 +50,6 @@ with the label of any of your runners (the default label
|
|||||||
is `self-hosted`):
|
is `self-hosted`):
|
||||||
|
|
||||||
```yaml
|
```yaml
|
||||||
|
|
||||||
# ...
|
# ...
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
@@ -59,9 +64,124 @@ jobs:
|
|||||||
|
|
||||||
## Configuration
|
## Configuration
|
||||||
|
|
||||||
You can pass additional options to the Dependency Review
|
Configure this action by either using an external configuration file,
|
||||||
Action using your workflow file. Here's an example workflow with
|
or by inlining these options in your workflow file.
|
||||||
all the possible configurations:
|
|
||||||
|
### Options
|
||||||
|
|
||||||
|
#### config-file
|
||||||
|
|
||||||
|
A string representing the path to an external configuraton file. By
|
||||||
|
default external configuration files are not used.
|
||||||
|
|
||||||
|
**Possible values**: A string representing the absolute path to the
|
||||||
|
configuration file.
|
||||||
|
|
||||||
|
**Example**: `config-file: ./.github/dependency-review-config.yml`.
|
||||||
|
|
||||||
|
#### fail-on-severity
|
||||||
|
|
||||||
|
Configure the severity level for alerting. See "[Vulnerability Severity](https://github.com/actions/dependency-review-action#vulnerability-severity)".
|
||||||
|
|
||||||
|
**Possible values**: `critical`, `high`, `moderate`, `low`.
|
||||||
|
|
||||||
|
**Example**: `fail-on-severity: moderate`.
|
||||||
|
|
||||||
|
#### fail-on-scopes
|
||||||
|
|
||||||
|
A list of strings representing the build environments you want to
|
||||||
|
support. The default value is `development, runtime`.
|
||||||
|
|
||||||
|
**Possible values**: `development`, `runtime`, `unknown`
|
||||||
|
|
||||||
|
**Inline example**: `fail-on-scopes: development, runtime`
|
||||||
|
|
||||||
|
**YAML example**:
|
||||||
|
```yaml
|
||||||
|
# this prevents scanning development dependencies
|
||||||
|
fail-on-scopes:
|
||||||
|
- runtime
|
||||||
|
```
|
||||||
|
|
||||||
|
#### allow-licenses
|
||||||
|
|
||||||
|
Only allow the licenses in this list. See "[Licenses](https://github.com/actions/dependency-review-action#licenses)".
|
||||||
|
|
||||||
|
**Possible values**: Any `spdx_id` value(s) from
|
||||||
|
https://docs.github.com/en/rest/licenses.
|
||||||
|
|
||||||
|
**Inline example**: `allow-licenses: BSD-3-Clause, MIT`
|
||||||
|
|
||||||
|
**YAML example**:
|
||||||
|
```yaml
|
||||||
|
allow-licenses:
|
||||||
|
- BSD-3-Clause
|
||||||
|
- MIT
|
||||||
|
```
|
||||||
|
|
||||||
|
#### deny-licenses
|
||||||
|
|
||||||
|
Add a custom list of licenses you want to block. See
|
||||||
|
"[Licenses](https://github.com/actions/dependency-review-action#licenses)".
|
||||||
|
|
||||||
|
**Possible values**: Any `spdx_id` value(s) from
|
||||||
|
https://docs.github.com/en/rest/licenses.
|
||||||
|
|
||||||
|
**Inline example**: `deny-licenses: LGPL-2.0, BSD-2-Clause`
|
||||||
|
|
||||||
|
**YAML example**:
|
||||||
|
```yaml
|
||||||
|
deny-licenses:
|
||||||
|
- LGPL-2.0
|
||||||
|
- BSD-2-Clause
|
||||||
|
```
|
||||||
|
|
||||||
|
#### base-ref/head-ref
|
||||||
|
|
||||||
|
Provide custom git references for the git base/head when performing
|
||||||
|
the comparison. If you are using pull requests, or
|
||||||
|
`pull_request_target` events you do not need to worry about setting
|
||||||
|
this. The values need to be specified for all other event types.
|
||||||
|
|
||||||
|
**Possible values**: Any valid git ref(s) in your project.
|
||||||
|
|
||||||
|
**Example**:
|
||||||
|
```yaml
|
||||||
|
base-ref: 8bb8a58d6a4028b6c2e314d5caaf273f57644896
|
||||||
|
head-ref: 69af5638bf660cf218aad5709a4c100e42a2f37b
|
||||||
|
```
|
||||||
|
|
||||||
|
### Configuration File
|
||||||
|
|
||||||
|
You can use an external configuration file to specify the settings for
|
||||||
|
this Action.
|
||||||
|
|
||||||
|
Start by specifying that you will be using an external configuration
|
||||||
|
file:
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
- name: Dependency Review
|
||||||
|
uses: actions/dependency-review-action@v2
|
||||||
|
with:
|
||||||
|
config-file: "./.github/dependency-review-config.yml"
|
||||||
|
```
|
||||||
|
|
||||||
|
And then create the file in the path you just specified. **All of these fields are
|
||||||
|
optional**:
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
fail-on-severity: "critical"
|
||||||
|
allow-licenses:
|
||||||
|
- "GPL-3.0"
|
||||||
|
- "BSD-3-Clause"
|
||||||
|
- "MIT"
|
||||||
|
```
|
||||||
|
|
||||||
|
### Inline Configuration
|
||||||
|
|
||||||
|
You can pass options to the Dependency Review
|
||||||
|
Action using your workflow file. Here's an example of what the full
|
||||||
|
file would look like:
|
||||||
|
|
||||||
```yaml
|
```yaml
|
||||||
name: 'Dependency Review'
|
name: 'Dependency Review'
|
||||||
@@ -77,26 +197,11 @@ jobs:
|
|||||||
- name: Dependency Review
|
- name: Dependency Review
|
||||||
uses: actions/dependency-review-action@v2
|
uses: actions/dependency-review-action@v2
|
||||||
with:
|
with:
|
||||||
# Possible values: "critical", "high", "moderate", "low"
|
fail-on-severity: moderate
|
||||||
# fail-on-severity: critical
|
|
||||||
#
|
|
||||||
# Possible values: Any available git ref
|
|
||||||
# base-ref: ${{ github.event.pull_request.base.ref }}
|
|
||||||
# head-ref: ${{ github.event.pull_request.head.ref }}
|
|
||||||
#
|
|
||||||
# You can only include one of these two options: `allow-licenses` and `deny-licenses`. These options are not supported on GHES.
|
|
||||||
#
|
|
||||||
# Possible values: Any `spdx_id` value(s) from https://docs.github.com/en/rest/licenses
|
|
||||||
# allow-licenses: GPL-3.0, BSD-3-Clause, MIT
|
|
||||||
#
|
|
||||||
# Possible values: Any `spdx_id` value(s) from https://docs.github.com/en/rest/licenses
|
|
||||||
# deny-licenses: LGPL-2.0, BSD-2-Clause
|
|
||||||
```
|
|
||||||
|
|
||||||
When the workflow with this action is caused by a `pull_request` or `pull_request_target` event,
|
# Use comma-separated names to pass list arguments:
|
||||||
the `base-ref` and `head-ref` values have the defaults as shown above. If the workflow is caused by
|
deny-licenses: LGPL-2.0, BSD-2-Clause
|
||||||
any other event, the `base-ref` and `head-ref` options must be
|
```
|
||||||
explicitly set in the configuration file.
|
|
||||||
|
|
||||||
### Vulnerability Severity
|
### Vulnerability Severity
|
||||||
|
|
||||||
@@ -114,12 +219,23 @@ This example will only fail on pull requests with `critical` and `high` vulnerab
|
|||||||
fail-on-severity: high
|
fail-on-severity: high
|
||||||
```
|
```
|
||||||
|
|
||||||
|
### Dependency Scoping
|
||||||
|
|
||||||
|
By default the action will only fail on `runtime` dependencies that have vulnerabilities or unacceptable licenses, ignoring `development` dependencies. You can override this behavior with the `fail-on-scopes` option, which will allow you to list the specific dependency scopes you care about. The possible values are: `unknown`, `runtime`, and `development`. Note: Filtering by scope will not be supported on Enterprise Server just yet, as the REST API's introduction of `scope` will be released in an upcoming Enterprise Server version. We will treat all dependencies on Enterprise Server as having a `runtime` scope and thus will not be filtered away.
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
- name: Dependency Review
|
||||||
|
uses: actions/dependency-review-action@v2
|
||||||
|
with:
|
||||||
|
fail-on-scopes: runtime, development
|
||||||
|
```
|
||||||
|
|
||||||
### Licenses
|
### Licenses
|
||||||
|
|
||||||
You can set the action to fail on pull requests based on the licenses of the dependencies
|
You can set the action to fail on pull requests based on the licenses of the dependencies
|
||||||
they introduce. With `allow-licenses` you can define the list of licenses
|
they introduce. With `allow-licenses` you can define the list of licenses
|
||||||
your repository will accept. Alternatively, you can use `deny-licenses` to only
|
your repository will accept. Alternatively, you can use `deny-licenses` to only
|
||||||
forbid a subset of licenses. These options are not supported on GHES.
|
forbid a subset of licenses. These options are not supported on Enterprise Server.
|
||||||
|
|
||||||
You can use the [Licenses
|
You can use the [Licenses
|
||||||
API](https://docs.github.com/en/rest/licenses) to see the full list of
|
API](https://docs.github.com/en/rest/licenses) to see the full list of
|
||||||
@@ -142,9 +258,9 @@ to filter. A couple of examples:
|
|||||||
deny-licenses: Apache-1.1, Apache-2.0
|
deny-licenses: Apache-1.1, Apache-2.0
|
||||||
```
|
```
|
||||||
|
|
||||||
**Important**
|
### Considerations
|
||||||
|
|
||||||
<<<<<<< HEAD
|
- Checking for licenses is not supported on Enterprise Server.
|
||||||
- The action will only accept one of the two parameters; an error will
|
- The action will only accept one of the two parameters; an error will
|
||||||
be raised if you provide both.
|
be raised if you provide both.
|
||||||
- By default both parameters are empty (no license checking is
|
- By default both parameters are empty (no license checking is
|
||||||
@@ -152,16 +268,6 @@ to filter. A couple of examples:
|
|||||||
- We don't have license information for all of your dependents. If we
|
- We don't have license information for all of your dependents. If we
|
||||||
can't detect the license for a dependency **we will inform you, but the
|
can't detect the license for a dependency **we will inform you, but the
|
||||||
action won't fail**.
|
action won't fail**.
|
||||||
=======
|
|
||||||
* Checking for licenses is not supported on GHES.
|
|
||||||
* The action will only accept one of the two parameters; an error will
|
|
||||||
be raised if you provide both.
|
|
||||||
* By default both parameters are empty (no license checking is
|
|
||||||
performed).
|
|
||||||
* We don't have license information for all of your dependents. If we
|
|
||||||
can't detect the license for a dependency **we will inform you, but the
|
|
||||||
action won't fail**.
|
|
||||||
>>>>>>> main
|
|
||||||
|
|
||||||
## Blocking pull requests
|
## Blocking pull requests
|
||||||
|
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import {expect, test, beforeEach} from '@jest/globals'
|
import {expect, test, beforeEach} from '@jest/globals'
|
||||||
import {readConfig} from '../src/config'
|
import {readConfig, readConfigFile} from '../src/config'
|
||||||
import {getRefs} from '../src/git-refs'
|
import {getRefs} from '../src/git-refs'
|
||||||
|
|
||||||
// GitHub Action inputs come in the form of environment variables
|
// GitHub Action inputs come in the form of environment variables
|
||||||
@@ -13,8 +13,10 @@ function setInput(input: string, value: string) {
|
|||||||
function clearInputs() {
|
function clearInputs() {
|
||||||
const allowedOptions = [
|
const allowedOptions = [
|
||||||
'FAIL-ON-SEVERITY',
|
'FAIL-ON-SEVERITY',
|
||||||
|
'FAIL-ON-SCOPES',
|
||||||
'ALLOW-LICENSES',
|
'ALLOW-LICENSES',
|
||||||
'DENY-LICENSES',
|
'DENY-LICENSES',
|
||||||
|
'CONFIG-FILE',
|
||||||
'BASE-REF',
|
'BASE-REF',
|
||||||
'HEAD-REF'
|
'HEAD-REF'
|
||||||
]
|
]
|
||||||
@@ -82,3 +84,79 @@ test('it raises an error when no refs are provided and the event is not a pull r
|
|||||||
})
|
})
|
||||||
).toThrow()
|
).toThrow()
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('it reads an external config file', async () => {
|
||||||
|
let options = readConfigFile('./__tests__/fixtures/config-allow-sample.yml')
|
||||||
|
expect(options.fail_on_severity).toEqual('critical')
|
||||||
|
expect(options.allow_licenses).toEqual(['BSD', 'GPL 2'])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('raises an error when the the config file was not found', async () => {
|
||||||
|
expect(() => readConfigFile('fixtures/i-dont-exist')).toThrow()
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it parses options from both sources', async () => {
|
||||||
|
setInput('config-file', './__tests__/fixtures/config-allow-sample.yml')
|
||||||
|
|
||||||
|
let options = readConfig()
|
||||||
|
expect(options.fail_on_severity).toEqual('critical')
|
||||||
|
|
||||||
|
setInput('base-ref', 'a-custom-base-ref')
|
||||||
|
options = readConfig()
|
||||||
|
expect(options.base_ref).toEqual('a-custom-base-ref')
|
||||||
|
})
|
||||||
|
|
||||||
|
test('in case of conflicts, the external config is the source of truth', async () => {
|
||||||
|
setInput('config-file', './__tests__/fixtures/config-allow-sample.yml') // this will set fail-on-severity to 'critical'
|
||||||
|
|
||||||
|
let options = readConfig()
|
||||||
|
expect(options.fail_on_severity).toEqual('critical')
|
||||||
|
|
||||||
|
// this should not overwite the previous value
|
||||||
|
setInput('fail-on-severity', 'low')
|
||||||
|
options = readConfig()
|
||||||
|
expect(options.fail_on_severity).toEqual('critical')
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it uses the default values when loading external files', async () => {
|
||||||
|
setInput('config-file', './__tests__/fixtures/no-licenses-config.yml')
|
||||||
|
let options = readConfig()
|
||||||
|
expect(options.allow_licenses).toEqual(undefined)
|
||||||
|
expect(options.deny_licenses).toEqual(undefined)
|
||||||
|
|
||||||
|
setInput('config-file', './__tests__/fixtures/license-config-sample.yml')
|
||||||
|
options = readConfig()
|
||||||
|
expect(options.fail_on_severity).toEqual('low')
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it accepts an external configuration filename', async () => {
|
||||||
|
setInput('config-file', './__tests__/fixtures/no-licenses-config.yml')
|
||||||
|
const options = readConfig()
|
||||||
|
expect(options.fail_on_severity).toEqual('critical')
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it raises an error when given an unknown severity in an external config file', async () => {
|
||||||
|
setInput('config-file', './__tests__/fixtures/invalid-severity-config.yml')
|
||||||
|
expect(() => readConfig()).toThrow()
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it defaults to runtime scope', async () => {
|
||||||
|
const options = readConfig()
|
||||||
|
expect(options.fail_on_scopes).toEqual(['runtime'])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it parses custom scopes preference', async () => {
|
||||||
|
setInput('fail-on-scopes', 'runtime, development')
|
||||||
|
let options = readConfig()
|
||||||
|
expect(options.fail_on_scopes).toEqual(['runtime', 'development'])
|
||||||
|
|
||||||
|
clearInputs()
|
||||||
|
setInput('fail-on-scopes', 'development')
|
||||||
|
options = readConfig()
|
||||||
|
expect(options.fail_on_scopes).toEqual(['development'])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('it raises an error when given invalid scope', async () => {
|
||||||
|
setInput('fail-on-scopes', 'runtime, zombies')
|
||||||
|
expect(() => readConfig()).toThrow()
|
||||||
|
})
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
import {expect, test} from '@jest/globals'
|
import {expect, test} from '@jest/globals'
|
||||||
import {Change, Changes} from '../src/schemas'
|
import {Change, Changes} from '../src/schemas'
|
||||||
import {filterChangesBySeverity} from '../src/filter'
|
import {filterChangesBySeverity, filterChangesByScopes} from '../src/filter'
|
||||||
|
|
||||||
let npmChange: Change = {
|
let npmChange: Change = {
|
||||||
manifest: 'package.json',
|
manifest: 'package.json',
|
||||||
@@ -11,6 +11,7 @@ let npmChange: Change = {
|
|||||||
package_url: 'pkg:npm/[email protected]',
|
package_url: 'pkg:npm/[email protected]',
|
||||||
license: 'MIT',
|
license: 'MIT',
|
||||||
source_repository_url: 'github.com/some-repo',
|
source_repository_url: 'github.com/some-repo',
|
||||||
|
scope: 'runtime',
|
||||||
vulnerabilities: [
|
vulnerabilities: [
|
||||||
{
|
{
|
||||||
severity: 'critical',
|
severity: 'critical',
|
||||||
@@ -30,6 +31,7 @@ let rubyChange: Change = {
|
|||||||
package_url: 'pkg:gem/[email protected]',
|
package_url: 'pkg:gem/[email protected]',
|
||||||
license: 'BSD',
|
license: 'BSD',
|
||||||
source_repository_url: 'github.com/some-repo',
|
source_repository_url: 'github.com/some-repo',
|
||||||
|
scope: 'development',
|
||||||
vulnerabilities: [
|
vulnerabilities: [
|
||||||
{
|
{
|
||||||
severity: 'moderate',
|
severity: 'moderate',
|
||||||
@@ -57,3 +59,16 @@ test('it properly filters changes by severity', async () => {
|
|||||||
result = filterChangesBySeverity('critical', changes)
|
result = filterChangesBySeverity('critical', changes)
|
||||||
expect(changes).toEqual([npmChange, rubyChange])
|
expect(changes).toEqual([npmChange, rubyChange])
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('it properly filters changes by scope', async () => {
|
||||||
|
const changes = [npmChange, rubyChange]
|
||||||
|
|
||||||
|
let result = filterChangesByScopes(['runtime'], changes)
|
||||||
|
expect(result).toEqual([npmChange])
|
||||||
|
|
||||||
|
result = filterChangesByScopes(['development'], changes)
|
||||||
|
expect(result).toEqual([rubyChange])
|
||||||
|
|
||||||
|
result = filterChangesByScopes(['runtime', 'development'], changes)
|
||||||
|
expect(result).toEqual([npmChange, rubyChange])
|
||||||
|
})
|
||||||
|
|||||||
@@ -0,0 +1,3 @@
|
|||||||
|
fail-on-severity: 'so many zombies'
|
||||||
|
deny-licenses:
|
||||||
|
- MIT
|
||||||
@@ -0,0 +1 @@
|
|||||||
|
allow_licenses: ['MIT', 'GPL 2']
|
||||||
@@ -11,6 +11,7 @@ let npmChange: Change = {
|
|||||||
package_url: 'pkg:npm/[email protected]',
|
package_url: 'pkg:npm/[email protected]',
|
||||||
license: 'MIT',
|
license: 'MIT',
|
||||||
source_repository_url: 'github.com/some-repo',
|
source_repository_url: 'github.com/some-repo',
|
||||||
|
scope: 'runtime',
|
||||||
vulnerabilities: [
|
vulnerabilities: [
|
||||||
{
|
{
|
||||||
severity: 'critical',
|
severity: 'critical',
|
||||||
@@ -30,6 +31,7 @@ let rubyChange: Change = {
|
|||||||
package_url: 'pkg:gem/[email protected]',
|
package_url: 'pkg:gem/[email protected]',
|
||||||
license: 'BSD',
|
license: 'BSD',
|
||||||
source_repository_url: 'github.com/some-repo',
|
source_repository_url: 'github.com/some-repo',
|
||||||
|
scope: 'runtime',
|
||||||
vulnerabilities: [
|
vulnerabilities: [
|
||||||
{
|
{
|
||||||
severity: 'moderate',
|
severity: 'moderate',
|
||||||
|
|||||||
@@ -10,12 +10,19 @@ inputs:
|
|||||||
description: Don't block PRs below this severity. Possible values are `low`, `moderate`, `high`, `critical`.
|
description: Don't block PRs below this severity. Possible values are `low`, `moderate`, `high`, `critical`.
|
||||||
required: false
|
required: false
|
||||||
default: 'low'
|
default: 'low'
|
||||||
|
fail-on-scopes:
|
||||||
|
description: Dependency scopes to block PRs on. Comma-separated list. Possible values are 'unknown', 'runtime', and 'development' (e.g. "runtime, development")
|
||||||
|
required: false
|
||||||
|
default: 'runtime'
|
||||||
base-ref:
|
base-ref:
|
||||||
description: The base git ref to be used for this check. Has a default value when the workflow event is `pull_request` or `pull_request_target`. Must be provided otherwise.
|
description: The base git ref to be used for this check. Has a default value when the workflow event is `pull_request` or `pull_request_target`. Must be provided otherwise.
|
||||||
required: false
|
required: false
|
||||||
head-ref:
|
head-ref:
|
||||||
description: The head git ref to be used for this check. Has a default value when the workflow event is `pull_request` or `pull_request_target`. Must be provided otherwise.
|
description: The head git ref to be used for this check. Has a default value when the workflow event is `pull_request` or `pull_request_target`. Must be provided otherwise.
|
||||||
required: false
|
required: false
|
||||||
|
config-file:
|
||||||
|
description: A filepath to the configuration file for the action.
|
||||||
|
required: false
|
||||||
allow-licenses:
|
allow-licenses:
|
||||||
description: Comma-separated list of allowed licenses (e.g. "MIT, GPL 3.0, BSD 2 Clause")
|
description: Comma-separated list of allowed licenses (e.g. "MIT, GPL 3.0, BSD 2 Clause")
|
||||||
required: false
|
required: false
|
||||||
|
|||||||
+8742
-172
File diff suppressed because it is too large
Load Diff
+1
-1
File diff suppressed because one or more lines are too long
+17
@@ -697,6 +697,23 @@ ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
|
|||||||
IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
||||||
|
|
||||||
|
|
||||||
|
yaml
|
||||||
|
ISC
|
||||||
|
Copyright Eemeli Aro <[email protected]>
|
||||||
|
|
||||||
|
Permission to use, copy, modify, and/or distribute this software for any purpose
|
||||||
|
with or without fee is hereby granted, provided that the above copyright notice
|
||||||
|
and this permission notice appear in all copies.
|
||||||
|
|
||||||
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||||
|
REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
|
||||||
|
FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||||
|
INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
|
||||||
|
OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
|
||||||
|
TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
|
||||||
|
THIS SOFTWARE.
|
||||||
|
|
||||||
|
|
||||||
zod
|
zod
|
||||||
MIT
|
MIT
|
||||||
MIT License
|
MIT License
|
||||||
|
|||||||
Generated
+278
-430
File diff suppressed because it is too large
Load Diff
+12
-12
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "dependency-review-action",
|
"name": "dependency-review-action",
|
||||||
"version": "2.0.4",
|
"version": "2.2.0",
|
||||||
"private": true,
|
"private": true,
|
||||||
"description": "A GitHub Action for Dependency Review",
|
"description": "A GitHub Action for Dependency Review",
|
||||||
"main": "lib/main.js",
|
"main": "lib/main.js",
|
||||||
@@ -29,26 +29,26 @@
|
|||||||
"@actions/github": "^5.0.3",
|
"@actions/github": "^5.0.3",
|
||||||
"@octokit/plugin-retry": "^3.0.9",
|
"@octokit/plugin-retry": "^3.0.9",
|
||||||
"@octokit/request-error": "^3.0.1",
|
"@octokit/request-error": "^3.0.1",
|
||||||
"ansi-styles": "^6.1.0",
|
"ansi-styles": "^6.1.1",
|
||||||
"got": "^12.3.1",
|
"got": "^12.5.0",
|
||||||
"nodemon": "^2.0.19",
|
"nodemon": "^2.0.20",
|
||||||
"yaml": "^2.1.1",
|
"yaml": "^2.1.1",
|
||||||
"zod": "^3.18.0"
|
"zod": "^3.19.1"
|
||||||
},
|
},
|
||||||
"devDependencies": {
|
"devDependencies": {
|
||||||
"@types/node": "^16.11.49",
|
"@types/node": "^16.11.59",
|
||||||
"@typescript-eslint/eslint-plugin": "^5.33.1",
|
"@typescript-eslint/eslint-plugin": "^5.38.0",
|
||||||
"@typescript-eslint/parser": "^5.33.1",
|
"@typescript-eslint/parser": "^5.38.0",
|
||||||
"@vercel/ncc": "^0.34.0",
|
"@vercel/ncc": "^0.34.0",
|
||||||
"esbuild-register": "^3.3.3",
|
"esbuild-register": "^3.3.3",
|
||||||
"eslint": "^8.22.0",
|
"eslint": "^8.23.1",
|
||||||
"eslint-plugin-github": "^4.3.7",
|
"eslint-plugin-github": "^4.3.7",
|
||||||
"eslint-plugin-jest": "^26.8.3",
|
"eslint-plugin-jest": "^27.0.4",
|
||||||
"jest": "^27.5.1",
|
"jest": "^27.5.1",
|
||||||
"js-yaml": "^4.1.0",
|
"js-yaml": "^4.1.0",
|
||||||
"nodemon": "^2.0.19",
|
"nodemon": "^2.0.20",
|
||||||
"prettier": "2.7.1",
|
"prettier": "2.7.1",
|
||||||
"ts-jest": "^27.1.4",
|
"ts-jest": "^27.1.4",
|
||||||
"typescript": "^4.7.4"
|
"typescript": "^4.8.3"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+15
-7
@@ -32,17 +32,25 @@ event_file = Tempfile.new
|
|||||||
event_file.write("{ \"pull_request\": #{pr.to_h.to_json}}")
|
event_file.write("{ \"pull_request\": #{pr.to_h.to_json}}")
|
||||||
event_file.close
|
event_file.close
|
||||||
|
|
||||||
dev_cmd_env = {
|
action_inputs = {
|
||||||
"INPUT_REPO-TOKEN" => github_token,
|
"repo-token" => github_token
|
||||||
"GITHUB_REPOSITORY" => repo_nwo,
|
|
||||||
"GITHUB_EVENT_NAME" => "pull_request",
|
|
||||||
"GITHUB_EVENT_PATH" => event_file.path
|
|
||||||
}
|
}
|
||||||
|
|
||||||
dev_cmd = "./node_modules/.bin/nodemon --exec \"node -r esbuild-register\" src/main.ts"
|
dev_cmd_env = {
|
||||||
|
"GITHUB_REPOSITORY" => repo_nwo,
|
||||||
|
"GITHUB_EVENT_NAME" => "pull_request",
|
||||||
|
"GITHUB_EVENT_PATH" => event_file.path,
|
||||||
|
"GITHUB_STEP_SUMMARY" => "/dev/null"
|
||||||
|
}
|
||||||
|
|
||||||
|
# bash does not like variable names with dashes like the ones Actions
|
||||||
|
# uses (e.g. INPUT_REPO-TOKEN). Passing them through `env` instead of
|
||||||
|
# manually setting them does the job.
|
||||||
|
action_inputs_env_str = action_inputs.map { |name, value| "\"INPUT_#{name.upcase}=#{value}\"" }.join(" ")
|
||||||
|
dev_cmd = "./node_modules/.bin/nodemon --exec \"env #{action_inputs_env_str} node -r esbuild-register\" src/main.ts"
|
||||||
|
|
||||||
Open3.popen2e(dev_cmd_env, dev_cmd) do |stdin, out|
|
Open3.popen2e(dev_cmd_env, dev_cmd) do |stdin, out|
|
||||||
while line = out.gets
|
while line = out.gets
|
||||||
puts line
|
puts line.gsub(github_token, "<REDACTED>")
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
+64
-7
@@ -1,17 +1,52 @@
|
|||||||
|
import * as fs from 'fs'
|
||||||
|
import path from 'path'
|
||||||
|
import YAML from 'yaml'
|
||||||
import * as core from '@actions/core'
|
import * as core from '@actions/core'
|
||||||
import * as z from 'zod'
|
import * as z from 'zod'
|
||||||
import {ConfigurationOptions, SEVERITIES} from './schemas'
|
import {
|
||||||
|
ConfigurationOptions,
|
||||||
|
ConfigurationOptionsSchema,
|
||||||
|
SeveritySchema,
|
||||||
|
SCOPES
|
||||||
|
} from './schemas'
|
||||||
|
|
||||||
function getOptionalInput(name: string): string | undefined {
|
function getOptionalInput(name: string): string | undefined {
|
||||||
const value = core.getInput(name)
|
const value = core.getInput(name)
|
||||||
return value.length > 0 ? value : undefined
|
return value.length > 0 ? value : undefined
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function parseList(list: string | undefined): string[] | undefined {
|
||||||
|
if (list === undefined) {
|
||||||
|
return list
|
||||||
|
} else {
|
||||||
|
return list.split(',').map(x => x.trim())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
export function readConfig(): ConfigurationOptions {
|
export function readConfig(): ConfigurationOptions {
|
||||||
const fail_on_severity = z
|
const externalConfig = getOptionalInput('config-file')
|
||||||
.enum(SEVERITIES)
|
if (externalConfig !== undefined) {
|
||||||
.default('low')
|
const config = readConfigFile(externalConfig)
|
||||||
.parse(getOptionalInput('fail-on-severity'))
|
// the reasoning behind reading the inline config when an external
|
||||||
|
// config file is provided is that we still want to allow users to
|
||||||
|
// pass inline options in the presence of an external config file.
|
||||||
|
const inlineConfig = readInlineConfig()
|
||||||
|
// the external config takes precedence
|
||||||
|
return Object.assign({}, inlineConfig, config)
|
||||||
|
} else {
|
||||||
|
return readInlineConfig()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
export function readInlineConfig(): ConfigurationOptions {
|
||||||
|
const fail_on_severity = SeveritySchema.parse(
|
||||||
|
getOptionalInput('fail-on-severity')
|
||||||
|
)
|
||||||
|
const fail_on_scopes = z
|
||||||
|
.array(z.enum(SCOPES))
|
||||||
|
.default(['runtime'])
|
||||||
|
.parse(parseList(getOptionalInput('fail-on-scopes')))
|
||||||
|
|
||||||
const allow_licenses = getOptionalInput('allow-licenses')
|
const allow_licenses = getOptionalInput('allow-licenses')
|
||||||
const deny_licenses = getOptionalInput('deny-licenses')
|
const deny_licenses = getOptionalInput('deny-licenses')
|
||||||
|
|
||||||
@@ -24,9 +59,31 @@ export function readConfig(): ConfigurationOptions {
|
|||||||
|
|
||||||
return {
|
return {
|
||||||
fail_on_severity,
|
fail_on_severity,
|
||||||
allow_licenses: allow_licenses?.split(',').map(x => x.trim()),
|
fail_on_scopes,
|
||||||
deny_licenses: deny_licenses?.split(',').map(x => x.trim()),
|
allow_licenses: parseList(allow_licenses),
|
||||||
|
deny_licenses: parseList(deny_licenses),
|
||||||
base_ref,
|
base_ref,
|
||||||
head_ref
|
head_ref
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function readConfigFile(filePath: string): ConfigurationOptions {
|
||||||
|
let data
|
||||||
|
|
||||||
|
try {
|
||||||
|
data = fs.readFileSync(path.resolve(filePath), 'utf-8')
|
||||||
|
} catch (error: unknown) {
|
||||||
|
throw error
|
||||||
|
}
|
||||||
|
data = YAML.parse(data)
|
||||||
|
|
||||||
|
// get rid of the ugly dashes from the actions conventions
|
||||||
|
for (const key of Object.keys(data)) {
|
||||||
|
if (key.includes('-')) {
|
||||||
|
data[key.replace(/-/g, '_')] = data[key]
|
||||||
|
delete data[key]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
const values = ConfigurationOptionsSchema.parse(data)
|
||||||
|
return values
|
||||||
|
}
|
||||||
|
|||||||
+14
-1
@@ -1,4 +1,4 @@
|
|||||||
import {Changes, Severity, SEVERITIES} from './schemas'
|
import {Changes, Severity, SEVERITIES, Scope} from './schemas'
|
||||||
|
|
||||||
export function filterChangesBySeverity(
|
export function filterChangesBySeverity(
|
||||||
severity: Severity,
|
severity: Severity,
|
||||||
@@ -33,3 +33,16 @@ export function filterChangesBySeverity(
|
|||||||
)
|
)
|
||||||
return filteredChanges
|
return filteredChanges
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function filterChangesByScopes(
|
||||||
|
scopes: Scope[],
|
||||||
|
changes: Changes
|
||||||
|
): Changes {
|
||||||
|
const filteredChanges = changes.filter(change => {
|
||||||
|
// if there is no scope on the change (Enterprise Server API for now), we will assume it is a runtime scope
|
||||||
|
const scope = change.scope || 'runtime'
|
||||||
|
return scopes.includes(scope)
|
||||||
|
})
|
||||||
|
|
||||||
|
return filteredChanges
|
||||||
|
}
|
||||||
|
|||||||
+28
-14
@@ -3,10 +3,11 @@ import * as dependencyGraph from './dependency-graph'
|
|||||||
import * as github from '@actions/github'
|
import * as github from '@actions/github'
|
||||||
import styles from 'ansi-styles'
|
import styles from 'ansi-styles'
|
||||||
import {RequestError} from '@octokit/request-error'
|
import {RequestError} from '@octokit/request-error'
|
||||||
import {Change, Severity} from './schemas'
|
import {Change, Severity, Scope} from './schemas'
|
||||||
import {readConfig} from '../src/config'
|
import {readConfig} from '../src/config'
|
||||||
import {filterChangesBySeverity} from '../src/filter'
|
import {filterChangesBySeverity, filterChangesByScopes} from '../src/filter'
|
||||||
import {getDeniedLicenseChanges} from './licenses'
|
import {getDeniedLicenseChanges} from './licenses'
|
||||||
|
import * as summary from './summary'
|
||||||
import {getRefs} from './git-refs'
|
import {getRefs} from './git-refs'
|
||||||
|
|
||||||
async function run(): Promise<void> {
|
async function run(): Promise<void> {
|
||||||
@@ -29,27 +30,36 @@ async function run(): Promise<void> {
|
|||||||
deny: config.deny_licenses
|
deny: config.deny_licenses
|
||||||
}
|
}
|
||||||
|
|
||||||
const filteredChanges = filterChangesBySeverity(
|
const scopes = config.fail_on_scopes
|
||||||
minSeverity as Severity,
|
|
||||||
changes
|
|
||||||
)
|
|
||||||
|
|
||||||
for (const change of filteredChanges) {
|
const scopedChanges = filterChangesByScopes(scopes as Scope[], changes)
|
||||||
if (
|
|
||||||
|
const addedChanges = filterChangesBySeverity(
|
||||||
|
minSeverity as Severity,
|
||||||
|
scopedChanges
|
||||||
|
).filter(
|
||||||
|
change =>
|
||||||
change.change_type === 'added' &&
|
change.change_type === 'added' &&
|
||||||
change.vulnerabilities !== undefined &&
|
change.vulnerabilities !== undefined &&
|
||||||
change.vulnerabilities.length > 0
|
change.vulnerabilities.length > 0
|
||||||
) {
|
)
|
||||||
printChangeVulnerabilities(change)
|
|
||||||
failed = true
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const [licenseErrors, unknownLicenses] = getDeniedLicenseChanges(
|
const [licenseErrors, unknownLicenses] = getDeniedLicenseChanges(
|
||||||
changes,
|
scopedChanges,
|
||||||
licenses
|
licenses
|
||||||
)
|
)
|
||||||
|
|
||||||
|
summary.addSummaryToSummary(addedChanges, licenseErrors, unknownLicenses)
|
||||||
|
|
||||||
|
if (addedChanges.length > 0) {
|
||||||
|
for (const change of addedChanges) {
|
||||||
|
printChangeVulnerabilities(change)
|
||||||
|
}
|
||||||
|
failed = true
|
||||||
|
}
|
||||||
|
|
||||||
|
summary.addChangeVulnerabilitiesToSummary(addedChanges, minSeverity || '')
|
||||||
|
|
||||||
if (licenseErrors.length > 0) {
|
if (licenseErrors.length > 0) {
|
||||||
printLicensesError(licenseErrors)
|
printLicensesError(licenseErrors)
|
||||||
core.setFailed('Dependency review detected incompatible licenses.')
|
core.setFailed('Dependency review detected incompatible licenses.')
|
||||||
@@ -57,6 +67,8 @@ async function run(): Promise<void> {
|
|||||||
|
|
||||||
printNullLicenses(unknownLicenses)
|
printNullLicenses(unknownLicenses)
|
||||||
|
|
||||||
|
summary.addLicensesToSummary(licenseErrors, unknownLicenses, config)
|
||||||
|
|
||||||
if (failed) {
|
if (failed) {
|
||||||
core.setFailed('Dependency review detected vulnerable packages.')
|
core.setFailed('Dependency review detected vulnerable packages.')
|
||||||
} else {
|
} else {
|
||||||
@@ -80,6 +92,8 @@ async function run(): Promise<void> {
|
|||||||
core.setFailed('Unexpected fatal error')
|
core.setFailed('Unexpected fatal error')
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
} finally {
|
||||||
|
await core.summary.write()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+10
-3
@@ -1,6 +1,9 @@
|
|||||||
import * as z from 'zod'
|
import * as z from 'zod'
|
||||||
|
|
||||||
export const SEVERITIES = ['critical', 'high', 'moderate', 'low'] as const
|
export const SEVERITIES = ['critical', 'high', 'moderate', 'low'] as const
|
||||||
|
export const SCOPES = ['unknown', 'runtime', 'development'] as const
|
||||||
|
|
||||||
|
export const SeveritySchema = z.enum(SEVERITIES).default('low')
|
||||||
|
|
||||||
export const ChangeSchema = z.object({
|
export const ChangeSchema = z.object({
|
||||||
change_type: z.enum(['added', 'removed']),
|
change_type: z.enum(['added', 'removed']),
|
||||||
@@ -11,10 +14,11 @@ export const ChangeSchema = z.object({
|
|||||||
package_url: z.string(),
|
package_url: z.string(),
|
||||||
license: z.string().nullable(),
|
license: z.string().nullable(),
|
||||||
source_repository_url: z.string().nullable(),
|
source_repository_url: z.string().nullable(),
|
||||||
|
scope: z.enum(SCOPES).optional(),
|
||||||
vulnerabilities: z
|
vulnerabilities: z
|
||||||
.array(
|
.array(
|
||||||
z.object({
|
z.object({
|
||||||
severity: z.enum(['critical', 'high', 'moderate', 'low']),
|
severity: SeveritySchema,
|
||||||
advisory_ghsa_id: z.string(),
|
advisory_ghsa_id: z.string(),
|
||||||
advisory_summary: z.string(),
|
advisory_summary: z.string(),
|
||||||
advisory_url: z.string()
|
advisory_url: z.string()
|
||||||
@@ -32,9 +36,11 @@ export const PullRequestSchema = z.object({
|
|||||||
|
|
||||||
export const ConfigurationOptionsSchema = z
|
export const ConfigurationOptionsSchema = z
|
||||||
.object({
|
.object({
|
||||||
fail_on_severity: z.enum(SEVERITIES).default('low'),
|
fail_on_severity: SeveritySchema,
|
||||||
|
fail_on_scopes: z.array(z.enum(SCOPES)).default(['runtime']),
|
||||||
allow_licenses: z.array(z.string()).default([]),
|
allow_licenses: z.array(z.string()).default([]),
|
||||||
deny_licenses: z.array(z.string()).default([]),
|
deny_licenses: z.array(z.string()).default([]),
|
||||||
|
config_file: z.string().optional().default('false'),
|
||||||
base_ref: z.string(),
|
base_ref: z.string(),
|
||||||
head_ref: z.string()
|
head_ref: z.string()
|
||||||
})
|
})
|
||||||
@@ -49,4 +55,5 @@ export const ChangesSchema = z.array(ChangeSchema)
|
|||||||
export type Change = z.infer<typeof ChangeSchema>
|
export type Change = z.infer<typeof ChangeSchema>
|
||||||
export type Changes = z.infer<typeof ChangesSchema>
|
export type Changes = z.infer<typeof ChangesSchema>
|
||||||
export type ConfigurationOptions = z.infer<typeof ConfigurationOptionsSchema>
|
export type ConfigurationOptions = z.infer<typeof ConfigurationOptionsSchema>
|
||||||
export type Severity = typeof SEVERITIES[number]
|
export type Severity = z.infer<typeof SeveritySchema>
|
||||||
|
export type Scope = typeof SCOPES[number]
|
||||||
|
|||||||
+163
@@ -0,0 +1,163 @@
|
|||||||
|
import * as core from '@actions/core'
|
||||||
|
import {ConfigurationOptions, Change, Changes} from './schemas'
|
||||||
|
import {SummaryTableRow} from '@actions/core/lib/summary'
|
||||||
|
|
||||||
|
export function addSummaryToSummary(
|
||||||
|
addedPackages: Changes,
|
||||||
|
licenseErrors: Change[],
|
||||||
|
unknownLicenses: Change[]
|
||||||
|
): void {
|
||||||
|
core.summary
|
||||||
|
.addHeading('Dependency Review')
|
||||||
|
.addRaw(
|
||||||
|
`We found ${addedPackages.length} vulnerable package(s), ${licenseErrors.length} package(s) with incompatible licenses, and ${unknownLicenses.length} package(s) with unknown licenses.`
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
export function addChangeVulnerabilitiesToSummary(
|
||||||
|
addedPackages: Changes,
|
||||||
|
severity: string
|
||||||
|
): void {
|
||||||
|
const rows: SummaryTableRow[] = []
|
||||||
|
|
||||||
|
const manifests = getManifests(addedPackages)
|
||||||
|
|
||||||
|
core.summary
|
||||||
|
.addHeading('Vulnerabilities')
|
||||||
|
.addQuote(
|
||||||
|
`Vulnerabilites were filtered by mininum severity <strong>${severity}</strong>.`
|
||||||
|
)
|
||||||
|
|
||||||
|
if (addedPackages.length === 0) {
|
||||||
|
core.summary.addQuote('No vulnerabilities found in added packages.')
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
for (const manifest of manifests) {
|
||||||
|
for (const change of addedPackages.filter(
|
||||||
|
pkg => pkg.manifest === manifest
|
||||||
|
)) {
|
||||||
|
let previous_package = ''
|
||||||
|
let previous_version = ''
|
||||||
|
for (const vuln of change.vulnerabilities) {
|
||||||
|
const sameAsPrevious =
|
||||||
|
previous_package === change.name &&
|
||||||
|
previous_version === change.version
|
||||||
|
|
||||||
|
if (!sameAsPrevious) {
|
||||||
|
rows.push([
|
||||||
|
renderUrl(change.source_repository_url, change.name),
|
||||||
|
change.version,
|
||||||
|
renderUrl(vuln.advisory_url, vuln.advisory_summary),
|
||||||
|
vuln.severity
|
||||||
|
])
|
||||||
|
} else {
|
||||||
|
rows.push([
|
||||||
|
{data: '', colspan: '2'},
|
||||||
|
renderUrl(vuln.advisory_url, vuln.advisory_summary),
|
||||||
|
vuln.severity
|
||||||
|
])
|
||||||
|
}
|
||||||
|
previous_package = change.name
|
||||||
|
previous_version = change.version
|
||||||
|
}
|
||||||
|
}
|
||||||
|
core.summary.addHeading(`<em>${manifest}</em>`, 3).addTable([
|
||||||
|
[
|
||||||
|
{data: 'Name', header: true},
|
||||||
|
{data: 'Version', header: true},
|
||||||
|
{data: 'Vulnerability', header: true},
|
||||||
|
{data: 'Severity', header: true}
|
||||||
|
],
|
||||||
|
...rows
|
||||||
|
])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
export function addLicensesToSummary(
|
||||||
|
licenseErrors: Change[],
|
||||||
|
unknownLicenses: Change[],
|
||||||
|
config: ConfigurationOptions
|
||||||
|
): void {
|
||||||
|
core.summary.addHeading('Licenses')
|
||||||
|
|
||||||
|
if (config.allow_licenses && config.allow_licenses.length > 0) {
|
||||||
|
core.summary.addQuote(
|
||||||
|
`<strong>Allowed Licenses</strong>: ${config.allow_licenses.join(', ')}`
|
||||||
|
)
|
||||||
|
}
|
||||||
|
if (config.deny_licenses && config.deny_licenses.length > 0) {
|
||||||
|
core.summary.addQuote(
|
||||||
|
`<strong>Denied Licenses</strong>: ${config.deny_licenses.join(', ')}`
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
if (licenseErrors.length === 0 && unknownLicenses.length === 0) {
|
||||||
|
core.summary.addQuote('No license violations detected.')
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
if (licenseErrors.length > 0) {
|
||||||
|
const rows: SummaryTableRow[] = []
|
||||||
|
const manifests = getManifests(licenseErrors)
|
||||||
|
|
||||||
|
core.summary.addHeading('Incompatible Licenses', 3).addSeparator()
|
||||||
|
|
||||||
|
for (const manifest of manifests) {
|
||||||
|
core.summary.addHeading(`<em>${manifest}</em>`, 4)
|
||||||
|
|
||||||
|
for (const change of licenseErrors.filter(
|
||||||
|
pkg => pkg.manifest === manifest
|
||||||
|
)) {
|
||||||
|
rows.push([
|
||||||
|
renderUrl(change.source_repository_url, change.name),
|
||||||
|
change.version,
|
||||||
|
change.license || ''
|
||||||
|
])
|
||||||
|
}
|
||||||
|
core.summary.addTable([['Package', 'Version', 'License'], ...rows])
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
core.summary.addQuote('No license violations detected.')
|
||||||
|
}
|
||||||
|
|
||||||
|
core.debug(`found ${unknownLicenses.length} unknown licenses`)
|
||||||
|
|
||||||
|
if (unknownLicenses.length > 0) {
|
||||||
|
const rows: SummaryTableRow[] = []
|
||||||
|
const manifests = getManifests(unknownLicenses)
|
||||||
|
|
||||||
|
core.debug(
|
||||||
|
`found ${manifests.entries.length} manifests for unknown licenses`
|
||||||
|
)
|
||||||
|
|
||||||
|
core.summary.addHeading('Unknown Licenses', 3).addSeparator()
|
||||||
|
|
||||||
|
for (const manifest of manifests) {
|
||||||
|
core.summary.addHeading(`<em>${manifest}</em>`, 4)
|
||||||
|
|
||||||
|
for (const change of unknownLicenses.filter(
|
||||||
|
pkg => pkg.manifest === manifest
|
||||||
|
)) {
|
||||||
|
rows.push([
|
||||||
|
renderUrl(change.source_repository_url, change.name),
|
||||||
|
change.version
|
||||||
|
])
|
||||||
|
}
|
||||||
|
|
||||||
|
core.summary.addTable([['Package', 'Version'], ...rows])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
function getManifests(changes: Changes): Set<string> {
|
||||||
|
return new Set(changes.flatMap(c => c.manifest))
|
||||||
|
}
|
||||||
|
|
||||||
|
function renderUrl(url: string | null, text: string): string {
|
||||||
|
if (url) {
|
||||||
|
return `<a href="${url}">${text}</a>`
|
||||||
|
} else {
|
||||||
|
return text
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user