Implement review fixes: semver library, scoping, case-insensitive matching, error logging, and configurable fail behavior (#7)

* Initial plan * Implement PR review comment fixes: semver library, error handling, case-insensitive matching, and rows scoping Co-authored-by: felickz <[email protected]> * Fix formatting and rebuild dist folder Co-authored-by: felickz <[email protected]> * Fix fail-closed logic and remove redundant @types/semver Co-authored-by: felickz <[email protected]> * Apply review feedback: fix empty range handling, add trimming, implement range check caching Co-authored-by: felickz <[email protected]> * Apply review feedback: align fail-closed behavior for empty version, fix TypeScript typing, normalize cache keys Co-authored-by: felickz <[email protected]> * Fix linter errors, optimize cache keys, and improve trimming logic Co-authored-by: felickz <[email protected]> * Add fail-open option for patch selection and optimize with preTrimmed flag Co-authored-by: felickz <[email protected]> * Enforce fail-closed with explicit validation, fix debug messages, normalize cache keys Co-authored-by: felickz <[email protected]> * Fix unreachable ternary in debug message and eliminate duplicate trim operation Co-authored-by: felickz <[email protected]> * Normalize eco comparison and add preNormalized option to avoid duplicate range conversion Co-authored-by: felickz <[email protected]> * Remove unnecessary cache, fix function signature, and correct semver comment Co-authored-by: felickz <[email protected]> * Make includePrerelease conditional based on version type to preserve range semantics Co-authored-by: felickz <[email protected]> * Improve debug message to report both invalid version and range when applicable Co-authored-by: felickz <[email protected]> * Convert to JSDoc, add explicit type annotation, and remove redundant initializer Co-authored-by: felickz <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: felickz <[email protected]>
2026-02-08 16:05:04 -05:00
parent 2af9bac14d
commit ee66ea100d
5 changed files with 240 additions and 122 deletions
@@ -20,6 +20,7 @@
        "got": "^14.4.7",
        "jest": "^29.7.0",
        "octokit": "^3.1.2",
+        "semver": "^7.7.4",
        "spdx-expression-parse": "^3.0.1",
        "spdx-satisfies": "^6.0.0",
        "ts-jest": "^29.4.1",
@@ -2649,10 +2650,11 @@
      }
    },
    "node_modules/@types/semver": {
-      "version": "7.5.5",
-      "resolved": "https://registry.npmjs.org/@types/semver/-/semver-7.5.5.tgz",
-      "integrity": "sha512-+d+WYC1BxJ6yVOgUgzK8gWvp5qF8ssV5r4nsDcZWKRWcDQLQ619tvWAxJQYGgBrO1MnLJC7a5GtiYsAoQ47dJg==",
-      "dev": true
+      "version": "7.7.1",
+      "resolved": "https://registry.npmjs.org/@types/semver/-/semver-7.7.1.tgz",
+      "integrity": "sha512-FmgJfu+MOcQ370SD0ev7EI8TlCAfKYU+B4m5T3yXc1CiRN94g/SZPtsCkk506aUDtlMnFZvasDwHHUcZUEaYuA==",
+      "dev": true,
+      "license": "MIT"
    },
    "node_modules/@types/spdx-expression-parse": {
      "version": "3.0.5",
@@ -8264,9 +8266,9 @@
      }
    },
    "node_modules/semver": {
-      "version": "7.7.2",
-      "resolved": "https://registry.npmjs.org/semver/-/semver-7.7.2.tgz",
-      "integrity": "sha512-RF0Fw+rO5AMf9MAyaRXI4AV0Ulj5lMHqVxxdSgiVbixSCXoEmmX/jk0CuJw4+3SqroYO9VoUh+HcuJivvtJemA==",
+      "version": "7.7.4",
+      "resolved": "https://registry.npmjs.org/semver/-/semver-7.7.4.tgz",
+      "integrity": "sha512-vFKC2IEtQnVhpT78h1Yp8wzwrf8CM+MzKMHGJZfBtzhZNycRFnXsHk6E5TxIkkMsgNS7mdX3AGB7x2QM2di4lA==",
      "license": "ISC",
      "bin": {
        "semver": "bin/semver.js"