addressing lint issues

This commit is contained in:
Ahmed ElMallah
2024-11-20 21:41:54 +00:00
parent eee97d8b03
commit c89b41fdc6
2 changed files with 4 additions and 7 deletions
-3
View File
@@ -9,7 +9,6 @@ export async function getDeniedChanges(
): Promise<Change[]> { ): Promise<Change[]> {
const changesDenied: Change[] = [] const changesDenied: Change[] = []
let hasDeniedPackage = false
for (const change of changes) { for (const change of changes) {
for (const denied of deniedPackages) { for (const denied of deniedPackages) {
if ( if (
@@ -17,7 +16,6 @@ export async function getDeniedChanges(
change.name === denied.name change.name === denied.name
) { ) {
changesDenied.push(change) changesDenied.push(change)
hasDeniedPackage = true
} }
} }
@@ -30,7 +28,6 @@ export async function getDeniedChanges(
} }
if (namespace && namespace === denied.namespace) { if (namespace && namespace === denied.namespace) {
changesDenied.push(change) changesDenied.push(change)
hasDeniedPackage = true
} }
} }
} }
+3 -3
View File
@@ -210,7 +210,7 @@ async function run(): Promise<void> {
} }
} }
function printVulnerabilitiesBlock( async function printVulnerabilitiesBlock(
addedChanges: Changes, addedChanges: Changes,
minSeverity: Severity, minSeverity: Severity,
warnOnly: boolean warnOnly: boolean
@@ -253,7 +253,7 @@ function printChangeVulnerabilities(change: Change): boolean {
return change.vulnerabilities.length > 0 return change.vulnerabilities.length > 0
} }
function printLicensesBlock( async function printLicensesBlock(
invalidLicenseChanges: Record<string, Changes>, invalidLicenseChanges: Record<string, Changes>,
warnOnly: boolean warnOnly: boolean
): Promise<boolean> { ): Promise<boolean> {
@@ -383,7 +383,7 @@ function printScannedDependencies(changes: Changes): void {
}) })
} }
function printDeniedDependencies( async function printDeniedDependencies(
changes: Changes, changes: Changes,
config: ConfigurationOptions config: ConfigurationOptions
): Promise<boolean> { ): Promise<boolean> {