more refactoring for getDeniedChanges

This commit is contained in:
Brandon Teng
2024-04-04 15:18:51 -05:00
parent 7cebd9d64d
commit a323510dae
3 changed files with 36 additions and 60 deletions
+8 -7
View File
@@ -3,21 +3,22 @@ import * as core from '@actions/core'
export async function getDeniedChanges(
changes: Change[],
deniedPackages: string[],
deniedGroups: string[]
deniedPackages: string[] = [],
deniedGroups: string[] = []
): Promise<Change[]> {
const changesDenied: Change[] = []
let hasDeniedPackage = false
for (const change of changes) {
change.name = change.name.toLowerCase()
const [name, version] = change.package_url.toLowerCase().split('@')
const [packageName, packageVersion] = change.package_url
.toLowerCase()
.split('@')
for (const denied of deniedPackages) {
const [deniedName, deniedVersion] = denied.toLowerCase().split('@')
if (
(!deniedVersion || version === deniedVersion) &&
name === deniedName
(!deniedVersion || packageVersion === deniedVersion) &&
packageName === deniedName
) {
changesDenied.push(change)
hasDeniedPackage = true
@@ -25,7 +26,7 @@ export async function getDeniedChanges(
}
for (const denied of deniedGroups) {
if (name.startsWith(denied.toLowerCase())) {
if (packageName.startsWith(denied.toLowerCase())) {
changesDenied.push(change)
hasDeniedPackage = true
}