From 7278093fa03d5523d517e10b73cc2a902c1cac0c Mon Sep 17 00:00:00 2001 From: Federico Builes Date: Tue, 14 Jun 2022 07:41:37 +0200 Subject: [PATCH] Clarify some of the error messages. --- src/main.ts | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/main.ts b/src/main.ts index 943b000..feff982 100644 --- a/src/main.ts +++ b/src/main.ts @@ -40,7 +40,7 @@ async function run(): Promise { if (licenseErrors.length > 0) { printLicensesError(licenseErrors, licenses) - core.setFailed('Dependency review detected prohibited licenses.') + core.setFailed('Dependency review detected incompatible licenses.') return } @@ -64,7 +64,7 @@ async function run(): Promise { throw new Error('Dependency review detected vulnerable packages.') } else { core.info( - `Dependency review did not detect any vulnerable packages with severity level "${minSeverity}" or above.` + `Dependency review did not detect any vulnerable packages with severity level "${minSeverity}" or higher.` ) } } catch (error) { @@ -126,16 +126,6 @@ function printLicensesError( let {allow = [], deny = []} = licenses - core.info('Dependency review detected prohibited licenses.') - - if (allow.length > 0) { - core.info('\nAllowed licenses: ' + allow.join(', ') + '\n') - } - - if (deny.length > 0) { - core.info('\nDenied licenses: ' + deny.join(', ') + '\n') - } - core.info('The following dependencies have incompatible licenses:\n') for (const change of changes) { core.info(