From 5bace73db3a5faf7cf935ddaa86918e5b4de9ba0 Mon Sep 17 00:00:00 2001
From: Justin Hutchings <jhutchings1@users.noreply.github.com>
Date: Mon, 4 Mar 2024 19:38:52 +0000
Subject: [PATCH] Fix undefined/null checks

---
 src/summary.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/summary.ts b/src/summary.ts
index 483405b..3e188d2 100644
--- a/src/summary.ts
+++ b/src/summary.ts
@@ -261,14 +261,17 @@ export function addScorecardToSummary(
   for (const dependency of scorecard.dependencies) {
     core.summary.addRaw(
       `<tr><td>${dependency.ecosystem}/${dependency.packageName}</td><td>${dependency.version}</td>
-      <td>${dependency.depsDevData?.scorecard.overallScore == undefined ? 'Unknown' : dependency.depsDevData?.scorecard.overallScore}</td>`,
+      <td>${dependency.depsDevData?.scorecard.overallScore === undefined || dependency.depsDevData?.scorecard.overallScore === null ? 'Unknown' : dependency.depsDevData?.scorecard.overallScore}</td>`,
       false
     )
     if (dependency.depsDevData?.scorecard.checks !== undefined) {
       let detailsTable =
         '<table><tr><th>Check</th><th>Score</th><th>Reason</th></tr>'
       for (const check of dependency.depsDevData?.scorecard.checks || []) {
-        let icon = (check.score < config.warn_on_openssf_scorecard_level) ? ":warning:" : ":green_circle:"
+        let icon =
+          check.score < config.warn_on_openssf_scorecard_level
+            ? ':warning:'
+            : ':green_circle:'
 
         detailsTable += `<tr><td>${check.name}</td><td>${check.score}</td><td>${icon} ${check.reason}</td></tr>`
       }