PR feedback

Co-authored-by: Federico Builes <[email protected]>
This commit is contained in:
cnagadya
2022-10-28 11:23:05 +02:00
committed by GitHub
co-authored by Federico Builes
parent 0144419c8e
commit 216fafaed5
4 changed files with 9 additions and 8 deletions
-1
View File
@@ -1,7 +1,6 @@
import * as core from '@actions/core'
import spdxSatisfies from 'spdx-satisfies'
import {Octokit} from 'octokit'
import {Change, Changes} from './schemas'
import {isSPDXValid} from './utils'
+1 -1
View File
@@ -129,7 +129,7 @@ function printLicensesBlock(
}
if (invalidLicenseChanges.unresolved.length > 0) {
core.warning(
'\nThe validity of the licenses of the dependecies below could not be determine. Ensure that they are valid spdx licenses:'
'\nThe validity of the licenses of the dependencies below could not be determined. Ensure that they are valid SPDX licenses:'
)
printLicensesError(invalidLicenseChanges.unresolved)
core.setFailed(
+2 -2
View File
@@ -12,7 +12,7 @@ export function addSummaryToSummary(
.addRaw('We found:')
.addList([
`${addedPackages.length} vulnerable package(s)`,
`${invalidLicenseChanges.unresolved.length} package(s) with unprocessable licenses`,
`${invalidLicenseChanges.unresolved.length} package(s) with invalid SPDX license definitions`,
`${invalidLicenseChanges.forbidden.length} package(s) with incompatible licenses`,
`${invalidLicenseChanges.unlicensed.length} package(s) with unknown licenses.`
])
@@ -114,7 +114,7 @@ export function addLicensesToSummary(
)
printLicenseViolation('Unknown Licenses', invalidLicenseChanges.unlicensed)
printLicenseViolation(
'Unvalidated Licenses',
'Invalid SPDX License Definitions',
invalidLicenseChanges.unresolved
)
}