Yusuke Kuoka and GitHub
52b97139b6
Bump chart version to v0.23.2 for ARC v0.27.3 ( #2514 )
...
Validate Helm Chart / Lint Chart (push) Has been cancelled
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
Ref #2490
2023-04-17 09:00:57 -04:00
Yusuke Kuoka and GitHub
3e0bc3f7be
Fix docker.sock permission error for non-dind Ubuntu 20.04 runners since v0.27.2 ( #2499 )
...
Validate Helm Chart / Lint Chart (push) Has been cancelled
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
#2490 has been happening since v0.27.2 for non-dind runners based on Ubuntu 20.04 runner images. It does not affect Ubuntu 22.04 non-dind runners(i.e. runners with dockerd sidecars) and Ubuntu 20.04/22.04 dind runners(i.e. runners without dockerd sidecars). However, presuming many folks are still using Ubuntu 20.04 runners and non-dind runners, we should fix it.
This change tries to fix it by defaulting to the docker group id 1001 used by Ubuntu 20.04 runners, and use gid 121 for Ubuntu 22.04 runners. We use the image tag to see which Ubuntu version the runner is based on. The algorithm is so simple- we assume it's Ubuntu-22.04-based if the image tag contains "22.04".
This might be a breaking change for folks who have already upgraded to Ubuntu 22.04 runners using their own custom runner images. Note again; we rely on the image tag to detect Ubuntu 22.04 runner images and use the proper docker gid- Folks using our official Ubuntu 22.04 runner images are not affected. It is a breaking change anyway, so I have added a remedy-
ARC got a new flag, `--docker-gid`, which defaults to `1001` but can be set to `121` or whatever gid the operator/admin likes. This can be set to `--docker-gid=121`, for example, if you are using your own custom runner image based on Ubuntu 22.04 and the image tag does not contain "22.04".
Fixes #2490
2023-04-17 21:30:41 +09:00
Nikola Jokic and GitHub
ba1ac0990b
Reordering methods and constants so it is easier to look it up ( #2501 )
2023-04-12 09:50:23 +02:00
76fe43e8e0
Update limit manager role permissions ADR ( #2500 )
...
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-04-11 16:25:43 +02:00
8869ad28bb
Fix e2e tests infinite looping when waiting for resources ( #2496 )
...
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-04-10 21:03:02 +02:00
Nikola Jokic and GitHub
b86af190f7
Extend manager roles to accept ephemeralrunnerset/finalizers ( #2493 )
2023-04-10 08:49:32 +02:00
1a491cbfe5
Fix the publish chart workflow ( #2489 )
...
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com >
2023-04-06 08:01:48 -04:00
Yusuke Kuoka and GitHub
087f20fd5d
Fix chart publishing workflow ( #2487 )
2023-04-05 12:20:12 -04:00
Hidetake Iwata and GitHub
a880114e57
chart: Bump version to 0.23.1 ( #2483 )
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
Validate Helm Chart / Lint Chart (push) Has been cancelled
2023-04-05 22:39:29 +09:00
e80bc21fa5
gha-runner-scale-set 0.4.0 release ( #2467 )
...
Validate Helm Chart / Lint Chart (push) Has been cancelled
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com >
2023-04-05 08:56:27 -04:00
Tingluo Huang and GitHub
56754094ea
Remove deprecated method. ( #2481 )
2023-04-04 15:15:11 -04:00
8fa4520376
Treat .ghe.com domain as hosted environment ( #2480 )
...
Co-authored-by: Nikola Jokic <jokicnikola07@gmail.com >
2023-04-04 14:43:45 -04:00
Nikola Jokic and GitHub
a804bf8b00
Add ImagePullPolicy to the AutoscalingListener, configurable through Manager env ( #2477 )
2023-04-04 19:07:20 +02:00
5dea6db412
Fix helm uninstall cleanup by adding finalizers and cleaning them from the controller ( #2433 )
...
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-04-03 21:06:12 +02:00
Bassem Dghaidi and GitHub
2a0b770a63
Add troubleshooting advice ( #2456 )
2023-04-03 07:01:15 -04:00
Stewart Thomson and GitHub
a7ef871248
Check if appID and instID are non-empty before attempting to parseInt ( #2463 )
2023-04-03 09:06:59 +09:00
Tingluo Huang and GitHub
e45e4c53f1
Add E2E test to assert self-signed CA support. ( #2458 )
2023-03-31 10:31:25 -04:00
Yusuke Kuoka and GitHub
a608abd124
actions-metrics: Do our best not to fail the whole event processing on no API creds ( #2459 )
Validate Helm Chart / Lint Chart (push) Has been cancelled
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
2023-03-31 20:42:25 +09:00
02d9add322
Fix bug preventing env variables from being specified ( #2450 )
...
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-03-30 09:40:28 -04:00
f5ac134787
Fix chart publishing workflow to not throw away releases between the latest and 0.21.0 ( #2453 )
...
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com >
2023-03-30 05:46:29 -04:00
Yusuke Kuoka and GitHub
42abad5def
chart: Bump version to 0.23.0 ( #2449 )
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
Validate Helm Chart / Lint Chart (push) Has been cancelled
2023-03-30 10:10:18 +09:00
514b7da742
Install Docker Compose v2 as a Docker CLI plugin ( #2326 )
...
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com >
2023-03-29 10:40:10 +09:00
Francesco Renzi and GitHub
c8e3bb5ec3
Remove containerMode from values ( #2442 )
2023-03-28 10:16:38 +01:00
878c9b8b49
runner: Use Docker socket via shared emptyDir instead of TCP/mTLS ( #2324 )
...
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com >
2023-03-28 11:29:16 +09:00
4536707af6
chart: Allow webhook server env to be set individually ( #2377 )
...
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com >
2023-03-28 11:18:07 +09:00
13802c5a6d
chart: Restricting the RBAC rules on secrets ( #2265 )
...
Co-authored-by: Waldek Herka <wherka-ama@users.noreply.github.com >
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com >
2023-03-28 08:43:33 +09:00
362fa5d52e
crd: Add enterprise, organization, repository, and runner labels to runnerdeployments print columns ( #2310 )
...
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com >
2023-03-28 08:43:01 +09:00
65184f1ed8
chart: Allow customization of admission webhook timeout ( #2398 )
...
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com >
2023-03-28 08:42:20 +09:00
c23e31123c
Housekeeping: move adrs/ to docs/ and update status ( #2443 )
...
Co-authored-by: Francesco Renzi <rentziass@github.com >
2023-03-27 10:38:27 -04:00
56e1c62ac2
Add labels to autoscaling runner set subresources to allow easier inspection ( #2391 )
...
Co-authored-by: Tingluo Huang <tingluohuang@github.com >
2023-03-27 11:19:34 +02:00
Bassem Dghaidi and GitHub
64cedff2b4
Delete e2e-test-dispatch-workflow.yaml ( #2441 )
2023-03-24 07:11:57 -04:00
Bassem Dghaidi and GitHub
37f93b794e
Enhance quickstart troubleshooting guidelines ( #2435 )
2023-03-23 11:40:58 -04:00
Francesco Renzi and GitHub
dc833e57a0
Add new workflows ( #2423 )
2023-03-23 14:39:37 +00:00
Tingluo Huang and GitHub
5228aded87
Update e2e workflow ( #2430 )
2023-03-21 14:11:47 -04:00
Bassem Dghaidi and GitHub
f49d08e4bc
Update 2022-12-05-adding-labels-k8s-resources.md ( #2420 )
Validate Helm Chart / Lint Chart (push) Has been cancelled
Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) / Lint Chart (push) Has been cancelled
2023-03-17 06:39:56 -04:00
Tingluo Huang and GitHub
064039afc0
Ignore extra dind container when contaerinMode.type=dind. ( #2418 )
2023-03-17 09:26:51 +01:00
e5d8d65396
Introduce ADR change for adding labels to our resources ( #2407 )
...
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com >
2023-03-16 11:02:42 -04:00
Bassem Dghaidi and GitHub
c465ace8fb
Update the values.yaml sample for improved clarity ( #2416 )
2023-03-16 11:02:18 -04:00
Tingluo Huang and GitHub
34f3878829
Fix helm chart rendering errors. ( #2414 )
2023-03-16 09:21:43 -04:00
Tingluo Huang and GitHub
44c3931d8e
Adding e2e workflows to test dind, kube mode and proxy ( #2412 )
2023-03-15 12:17:11 -04:00
Tingluo Huang and GitHub
08acb1b831
Get RunnerScaleSet based on both RunnerGroupId and Name. ( #2413 )
2023-03-15 11:10:09 -04:00
Tingluo Huang and GitHub
40811ebe0e
Support the controller to watching a single namespace. ( #2374 )
2023-03-14 10:52:25 -04:00
3417c5a3a8
Update runner to version 2.303.0 ( #2411 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-03-14 15:41:03 +01:00
Bassem Dghaidi and GitHub
172faa883c
Fix GITHUB_TOKEN permissions ( #2410 )
2023-03-14 10:38:04 -04:00
Tingluo Huang and GitHub
9e6c7d019f
Delay role/rolebinding creation to gha-runner-scale-set installation time ( #2363 )
2023-03-14 09:45:44 -04:00
Bassem Dghaidi and GitHub
9fbcafa703
Fix canary image tag name ( #2409 )
2023-03-14 09:29:10 -04:00
Tingluo Huang and GitHub
2bf83d0d7f
Remove list/watch secrets permission from the manager cluster role. ( #2276 )
2023-03-14 09:23:14 -04:00
Bassem Dghaidi and GitHub
19d30dea5f
Add docker buildx pre-requisites ( #2408 )
2023-03-14 09:22:38 -04:00
Bassem Dghaidi and GitHub
6c66c1633f
Prevent releases on wrong tag name ( #2406 )
2023-03-14 09:13:25 -04:00
Bassem Dghaidi and GitHub
e55708588b
Add gha-runner-scale-set-controller canary build ( #2405 )
2023-03-14 09:12:53 -04:00
