actions/actions-runner-controller
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
1,662 Commits 33 Branches 147 Tags
revert-client-go-rlimits
Commit Graph
370 Commits
Author SHA1 Message Date
Nikola JokicandGitHub a804bf8b00 Add ImagePullPolicy to the AutoscalingListener, configurable through Manager env (#2477) 2023-04-04 19:07:20 +02:00
Nikola JokicGitHubTingluo Huang
 		5dea6db412 Fix helm uninstall cleanup by adding finalizers and cleaning them from the controller (#2433) 
Co-authored-by: Tingluo Huang <[email protected]>
 2023-04-03 21:06:12 +02:00
Stewart ThomsonandGitHub a7ef871248 Check if appID and instID are non-empty before attempting to parseInt (#2463) 2023-04-03 09:06:59 +09:00
Milas BowmanGitHubYusuke Kuoka
 		878c9b8b49 runner: Use Docker socket via shared emptyDir instead of TCP/mTLS (#2324) 
Co-authored-by: Yusuke Kuoka <[email protected]>
 2023-03-28 11:29:16 +09:00
Nikola JokicGitHubTingluo Huang
 		56e1c62ac2 Add labels to autoscaling runner set subresources to allow easier inspection (#2391) 
Co-authored-by: Tingluo Huang <[email protected]>
 2023-03-27 11:19:34 +02:00
Tingluo HuangandGitHub 08acb1b831 Get RunnerScaleSet based on both RunnerGroupId and Name. (#2413) 2023-03-15 11:10:09 -04:00
Tingluo HuangandGitHub 2bf83d0d7f Remove list/watch secrets permission from the manager cluster role. (#2276) 2023-03-14 09:23:14 -04:00
Tingluo HuangandGitHub 261d4371b5 Update E2E test workflow. (#2395) 2023-03-14 09:00:07 -04:00
Nikola JokicandGitHub babbfc77d5 Surface EphemeralRunnerSet stats to AutoscalingRunnerSet (#2382) 2023-03-13 16:16:28 +01:00
Tingluo HuangandGitHub d7b589bed5 Helm chart react changes for the new runner image. (#2348) 2023-03-10 11:18:21 +00:00
Francesco RenziGitHubBassem DghaidiNikola JokicTingluo Huang
 		c569304271 Add support for self-signed CA certificates (#2268) 
Co-authored-by: Bassem Dghaidi <[email protected]>
Co-authored-by: Nikola Jokic <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
 2023-03-09 17:23:32 +00:00
Chris PattersonGitHubTingluoHuang
 		41f2ca3ed9 Adding parameter to configure the runner set name. (#2279) 
Co-authored-by: TingluoHuang <[email protected]>
 2023-03-03 08:36:14 -05:00
Francesco RenziandGitHub 40c905f25d Simplify the setup of controller tests (#2352) 2023-03-02 18:55:49 +00:00
Nikola JokicandGitHub 2984de912c Split listener pod label to avoid long names issue (#2341) 2023-03-02 17:25:50 +01:00
Alex WilliamsGitHubYusuke Kuoka
 		69abd51f30 Ensure that EffectiveTime is updated on webhook scale down (#2258) 
Co-authored-by: Yusuke Kuoka <[email protected]>
 2023-03-01 08:27:37 +09:00
Francesco RenziandGitHub 73e22a1756 Disable metrics serving in proxy tests (#2307) 2023-02-22 16:57:59 +00:00
Francesco RenziGitHubNikola JokicTingluo HuangFerenc Hammerl
 		6b4250ca90 Add support for proxy (#2286) 
Co-authored-by: Nikola Jokic <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
Co-authored-by: Ferenc Hammerl <[email protected]>
 2023-02-21 17:33:48 +00:00
Nathan KlickandGitHub ced88228fc Resolves the erroneous webhook scale down due to check runs (#2119) 
Signed-off-by: Nathan Klick <[email protected]>
 2023-02-21 10:56:46 +09:00
Andrei VydrinGitHubYusuke Kuoka
 		44c06c21ce fix: case-insensitive webhook label matching (#2302) 
Co-authored-by: Yusuke Kuoka <[email protected]>
 2023-02-21 09:37:42 +09:00
Nikola JokicGitHubTingluo Huang
 		8e52a6d2cf EphemeralRunner: On cleanup, if pod is pending, delete from service (#2255) 
Co-authored-by: Tingluo Huang <[email protected]>
 2023-02-11 19:55:12 -05:00
Nikola JokicandGitHub 9990243520 Early return if finalizer does not exist to make it more readable (#2262) 2023-02-08 15:21:13 +01:00
Tingluo HuangandGitHub facae69e0b Remove un-required permissions for the manager-role of the new AutoScalingRunnerSet (#2260) 2023-02-07 12:37:09 -05:00
Nikola JokicandGitHub c4297d25bb Avoid deleting scale set if annotation is not parsable or if it does not exist (#2239) 2023-02-03 17:27:31 +01:00
Tingluo HuangandGitHub 1f4fe4681e Delete RunnerScaleSet on service when AutoScalingRunnerSet is deleted. (#2223) 2023-01-31 15:03:11 -05:00
Tingluo HuangandGitHub 803818162c Allow update runner group for AutoScalingRunnerSet (#2216) 2023-01-27 09:27:52 -05:00
dependabot[bot]GitHubdependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Yusuke Kuoka
 		219ba5b477 chore(deps): bump sigs.k8s.io/controller-runtime from 0.13.1 to 0.14.1 (#2132) 
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kuoka <[email protected]>
 2023-01-27 09:23:28 +09:00
Nikola JokicandGitHub 882bfab569 Renaming autoScaling to autoscaling in tests matching the convention (#2201) 2023-01-23 17:03:01 +01:00
Tingluo HuangandGitHub 4932412cd6 Fix L0 test to make it more reliable. (#2178) 2023-01-19 07:33:04 -05:00
Tingluo HuangandGitHub bb61bb1342 Include extra user-agent for runners created by actions-runner-controller. (#2177) 2023-01-18 07:38:59 +09:00
Tingluo HuangGitHubCory MillerNikola JokicAva StancuFerenc HammerlFrancesco RenziBassem Dghaidi
 		622eaa34f8 Introduce new preview auto-scaling mode for ARC. (#2153) 
Co-authored-by: Cory Miller <[email protected]>
Co-authored-by: Nikola Jokic <[email protected]>
Co-authored-by: Ava Stancu <[email protected]>
Co-authored-by: Ferenc Hammerl <[email protected]>
Co-authored-by: Francesco Renzi <[email protected]>
Co-authored-by: Bassem Dghaidi <[email protected]>
 2023-01-17 12:06:20 -05:00
Tingluo HuangandGitHub 044c8ad4d5 Include actions-runner-controller in runner's User-Agent for better telemetry in Actions service. (#2155) 2023-01-15 09:35:56 +09:00
Tingluo HuangGitHubBassem Dghaidi
 		eaa451df32 Update controller package names to match the owning API group name (#2150) 
* Update controller package names to match the owning API group name

* feedback.

Co-authored-by: Bassem Dghaidi <[email protected]>
 2023-01-13 08:24:11 +09:00
Yusuke KuokaandGitHub bc4f4fee12 Fix various golangci-lint errors (#2147) 
that we introduced via controller-runtime upgrade and via the removal of legacy pull-based scale triggers (#2001).
 2023-01-13 07:14:36 +09:00
Nikola JokicGitHubYusuke Kuoka
 		aa6dab5a9a Changes to folder structure to allow multigroups and changed go mod name (#2105) 
* Changed folder structure to allow multi group registration

* included actions.github.com directory for resources and controllers

* updated go module to actions/actions-runner-controller

* publish arc packages under actions-runner-controller

* Update charts/actions-runner-controller/docs/UPGRADING.md

Co-authored-by: Yusuke Kuoka <[email protected]>
 2022-12-28 09:38:34 +09:00
Callum TaitGitHubtoast-gear
 		418f719bdf chore: highlight watch namespace (#2087) 
* chore: highlight watch namespace

* chore: wording

Co-authored-by: toast-gear <[email protected]>
 2022-12-12 08:39:04 +09:00
Yusuke KuokaandGitHub 96a930bfd9 Fix runner pod to not stuck in Terminating when runner got deleted before pod scheduling (#2043) 
This fixes the said issue that I found while I was running a series of E2E tests to test other features and pull requestes I have recently contributed.
 2022-11-27 11:13:38 +09:00
Yusuke KuokaandGitHub ae86b1a011 Use the patch API instead to prevent unnecessary field updates (#1998) 
Fixes #1916
 2022-11-22 12:09:24 +09:00
Yusuke KuokaandGitHub 86d7893d61 breaking: Make legacy webhook scale triggers no-op (#2001) 
Ref #1607
 2022-11-22 12:08:29 +09:00
Igor SarkisovandGitHub 8f374d561f Do not explicitly set Privileged to false. (#2009) 
Setting SecurityContext.Privileged bit to false, which is default,
prevents GKE from admitting Windows pods.  Privileged bit is not
supported on Windows.
 2022-11-15 11:29:37 +09:00
malachiobadeyiGitHubYusuke Kuoka
 		fbdfe0df8c 1770 update log format and add additional fields to webhook server logs (#1771) 
* 1770 update log format and add runID and Id to worflow logs

update tests, change log format for controllers.HorizontalRunnerAutoscalerGitHubWebhook

use logging package

remove unused modules

add setup name to setuplog

add flag to change log format

change flag name to enableProdLogConfig

move log opts to logger package

remove empty else and reset timeEncoder

update flag description

use get function to handle nil

rename flag and update logger function

Update main.go

Co-authored-by: Yusuke Kuoka <[email protected]>

Update controllers/horizontal_runner_autoscaler_webhook.go

Co-authored-by: Yusuke Kuoka <[email protected]>

Update logging/logger.go

Co-authored-by: Yusuke Kuoka <[email protected]>

copy log opt per each NewLogger call

revert to use autoscaler.log

update flag descript and remove unused imports

add logFormat to readme

 rename setupLog to logger

make fmt

* Fix E2E along the way

Co-authored-by: Yusuke Kuoka <[email protected]>
 2022-11-04 10:46:58 +09:00
Yusuke KuokaandGitHub 23c8fe4a8b Fix dead-lock when runner unregistration triggered before PV attachment (#1975) 
This fixes an issue discovered while I was testing #1759. Please see the new comment in code for more information.
 2022-11-04 06:29:19 +09:00
Yusuke KuokaandGitHub c74ad6195f Fix runners to do their best to gracefully stop on pod eviction (#1759) 
Ref #1535
Ref #1581

Signed-off-by: Yusuke Kuoka <[email protected]>
 2022-11-01 20:30:10 +09:00
Yusuke KuokaandGitHub 710e2fbc3a Prevent runner controller from recreating runner pod when pod was terminated externally (#1851) 2022-10-13 09:04:50 +09:00
Yusuke KuokaandGitHub 7ff5b7da8c Handle missing runner ID more gracefully (#1855) 
so that ARC respect the registration timeout, terminationGracePeriodSeconds and RUNNER_GRACEFUL_STOP_TIMEOUT(#1759) when the runner pod was terminated externally too early after its creation

While I was running E2E tests for #1759, I discovered a potential issue that ARC can terminate runner pods without waiting for the registration timeout of 10 minutes.

You won't be affected by this in normal circumstances, as this failure scenario can be triggered only when you or another K8s controller like cluster-autoscaler deleted the runner or the runner pod immediately after the runner or the runner pod has been created. But probably is it worth fixing it anyway because it's not impossible to trigger it?
 2022-10-09 16:52:51 +09:00
Nicholas FarleyandGitHub a389292478 Allow RunnerDeployments to configure dnsPolicy for runners (#1892) 
* Add DnsPolicy field to RunnerPodSpec struct

* Ensure the runnerSpec's DNSPolicy is mirrored to the pod.Spec

* Run `make manifests`
 2022-10-05 08:16:11 +09:00
Yusuke Kuoka e4879e7ae4 Tweak E2E and documentation about MTU configuration 2022-09-25 07:50:12 +09:00
renovate[bot]GitHubrenovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Yusuke Kuoka
 		0deb6809b9 fix(deps): update module sigs.k8s.io/controller-runtime to v0.13.0 (#1775) 
* fix(deps): update module sigs.k8s.io/controller-runtime to v0.13.0

* fixup! fix(deps): update module sigs.k8s.io/controller-runtime to v0.13.0

* fixup! fixup! fix(deps): update module sigs.k8s.io/controller-runtime to v0.13.0

* fixup! fixup! fixup! fix(deps): update module sigs.k8s.io/controller-runtime to v0.13.0

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kuoka <[email protected]>
 2022-09-21 11:04:07 +09:00
Cory MillerandGitHub c91e76f169 Add golangci-lilnt to CI (#1794) 
This introduces a linter to PRs to help with code reviews and code hygiene. I've also gone ahead and fixed (or ignored) the existing lints.

I've only setup the default linters right now. There are many more options that are documented at https://golangci-lint.run/.

The GitHub Action should add appropriate annotations to the lint job for the PR. Contributors can also lint locally using `make lint`.
 2022-09-21 09:08:22 +09:00
Barun MishraandGitHub 921daff61b Add cmd line arg for enterprise url. Fix enterprise bug. (#1) 
* Add cmd line arg for enterprise url. Fix enterprise bug.

* Fix package import order

* Fix comment
 2022-09-05 13:50:17 +01:00
Yusuke Kuoka d4fb6204cb Add TODO comment to the PVC reconciler 2022-08-27 07:14:16 +00:00