actions/actions-runner-controller
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Autoscaling: Percentage runners busy - remove magic number used for round up (#235)

Browse Source 
* remove magic number for autoscaling

Co-authored-by: Zachary Benamram <[email protected]>
This commit is contained in:
ZacharyBenamram
2020-12-15 14:38:01 +09:00
committed by GitHub
co-authored by Zachary Benamram
parent 466b30728d
commit 48923fec56
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/autoscaling.go
+2 -1
View File
@@ -4,6 +4,7 @@ import (
"context" "context"
"errors" "errors"
"fmt" "fmt"
"math"
"strconv" "strconv"
"strings" "strings"
@@ -218,7 +219,7 @@ func (r *HorizontalRunnerAutoscalerReconciler) calculateReplicasByPercentageRunn
var desiredReplicas int var desiredReplicas int
fractionBusy := float64(numRunnersBusy) / float64(numRunners) fractionBusy := float64(numRunnersBusy) / float64(numRunners)
if fractionBusy >= scaleUpThreshold { if fractionBusy >= scaleUpThreshold {
scaleUpReplicas := int(float64(numRunners)*scaleUpFactor + 0.5) scaleUpReplicas := int(math.Ceil(float64(numRunners) * scaleUpFactor))
if scaleUpReplicas > maxReplicas { if scaleUpReplicas > maxReplicas {
desiredReplicas = maxReplicas desiredReplicas = maxReplicas
} else { } else {